Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

Fix: JTAG timings#1311

Merged
esden merged 4 commits into
mainfrom
fix/jtag-timings
Nov 28, 2022
Merged

Fix: JTAG timings#1311
esden merged 4 commits into
mainfrom
fix/jtag-timings

Conversation

@dragonmux
Copy link
Copy Markdown
Member

Detailed description

In this PR we address the JTAG timing issues that the earlier refactor in #1118 accidentally introduced. These timings issues impact the ability for the JTAG-PDI branch to function, and made the timings for ARM parts marginal. The timings issues occur while doing TMS sequences.

The following captures show the before-and-after of this timing fix:

image

image

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Bug Confirmed bug BMP Firmware Black Magic Probe Firmware (not PC hosted software) Regression Bug caused by a regression labels Nov 27, 2022
@dragonmux dragonmux added this to the v1.9 release milestone Nov 27, 2022
@dragonmux dragonmux requested a review from esden November 27, 2022 16:32
Copy link
Copy Markdown
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 14e9df6 into main Nov 28, 2022
@dragonmux dragonmux deleted the fix/jtag-timings branch November 28, 2022 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

BMP Firmware Black Magic Probe Firmware (not PC hosted software) Bug Confirmed bug Regression Bug caused by a regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants