This repository was archived by the owner on Mar 7, 2026. It is now read-only.
samd: Fixes for the "hosted" build#991
Merged
Merged
Conversation
…ong was 32-bit
Member
|
I saw that issue. We should ask the hosted build to the github actions so we can catch these kind of problems. Thanks for the patch! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code from #987 assumed unsigned long was 32-bit, which is not true for x86_64 Linux/Mac and other potential Black Magic App targets. This generally fixes the soundness of the type punting going on.