Open
Conversation
dragonmux
added
Documentation
dragonmux
reviewed
Sep 20, 2024
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
Only seen the one thing that could do with tweaking and it's only because of some debugging we did today. Otherwise this looks good to merge as-is.
|
|
||
| > [!NOTE] | ||
| > Some newer versions of meson have changed the syntax of the build script which will cause errors during this step. You may need to modify the script | ||
| as follows: Find the line in the file `meson.build` with `'b_debug=if-release'` and change it to `'debug=false'` and try rerunning the setup command. |
Member
There was a problem hiding this comment.
Some further debugging turned up that the option is actually b_ndebug - so, we'll make a commit changing the b_debug line to b_ndebug=if-release which works and is fine. Till we do that, the advice should be to correct the option name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick-n-dirty README.md file based on some conversation on the 1bitsquared discord.