Skip to content

Conversation

@azachar
Copy link
Contributor

@azachar azachar commented Dec 18, 2017

Hi there,

this is a WIP PR preview of trace log downloading and filtering.
I have added a dialog and some fancy features to operate on a daily basis with GitLab's logs.
So if you run some protractor tests that you need to examine, this should help a lot.

Here is a list of some features:
opens: GitLab page for pipelines, pipeline or job
downloads: trace log, all failed trace logs
filter: based on your domain package your failed stack traces (you need to install additional package for enabling this)
editor: support opening log with an ANSI editor that allows custom filtering
key bindings: to open GitLab's pipelines page and the job selector (ctrl+alt+g) and (shift+ctrl+alt+g)

Unfortunately, download progress is not shown yet. But perhaps some nice contributors could extend this and polish. Also, tests are missing.

Currently, some features are borrowed from additional 2 packages that need to be installed, otherwise filtering will not work that nicely. All is in mentioned in readme.

Hope to hear some feedback from you.

Cheers,
Andrej

opens: GitLab page for pipelines, pipeline or job
downloads: trace log, all failed trace logs
editor: support opening log with an ANSI editor that allows custom filtering
key bindings: to open GitLab's pipelines page and the job selector
@blakawk blakawk self-requested a review January 6, 2018 00:10
Copy link
Owner

@blakawk blakawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split your PR in several smaller ones and avoid referencing your packages directly. An user installing gitlab-integration should be able to use it without cloning from github.

@azachar azachar force-pushed the feat-trace-log-downloading branch from 283222f to 50a4c3a Compare January 15, 2018 23:51
Copy link
Owner

@blakawk blakawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size of this merge request, I did not have time to review it all. Please be patient.

@azachar
Copy link
Contributor Author

azachar commented Jan 21, 2018

Well, It really becomes an epic, I agree :). So take your time. As being said it is a preview, an experiment. I am just testing what suites my needs perhaps you can pick it up and bring it to the next level. I am sure that features like caching and data model needs to be completely rewritten. But for now it "works for me" and it already brings a lot of things such us pipeline selector for all pipelines, statistics to find out which jobs are problematic and so on... Have a look yourself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants