Maintain key order when restoring references #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when called with
{ references: true }, objects containing a repeated or circular reference will not have the property in question set until after the initialiser is done. This means that the key order may change from the original.Now admittedly, the key order is not guaranteed by ECMAScript in the first place, but the fix that's required is really rather minimal; just put in an
undefinedvalue during the initialiser and replace that in the subsequent assignment. This would also make objects more closely match the current behaviour of arrays.