-
Notifications
You must be signed in to change notification settings - Fork 20
add UI colors configuration for cast button styles across systems #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces UI color theming infrastructure by creating a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…k for whitelabel versions of bs
|
que bonito! |
This pull request introduces a consistent, dynamic color theming system across multiple UI components by integrating the
useUIColorshook and replacing hardcoded color values with theme-driven styles. The changes focus on improving maintainability and user experience by ensuring that primary colors and hover states are derived from a central theme, making it easier to update and manage UI colors throughout the app.Theme integration and UI consistency:
Added the
useUIColorshook to various components (reorderable-tab.tsx,ClaimButtonWithModal.tsx,ClaimModal.tsx,MiniAppSettings.tsx,ThemeColorSelector.tsx,FidgetSettingsEditor.tsx,FidgetTray.tsx,MobileHeader.tsx) to provide access to theme colors. [1] [2] [3] [4] [5] [6] [7]Updated button and interactive element styles to use
uiColors.primaryColoranduiColors.primaryHoverColorfor background, text, and hover states, replacing previous hardcoded color classes and inline styles. This affects components such as claim buttons, sign-in buttons, fidget tray add button, fidget settings submit button, and mini app settings toggles. [1] [2] [3] [4] [5]Component-specific improvements:
Refactored tab styling in
reorderable-tab.tsxto use theme colors for selection, hover, and underline, improving visual consistency and accessibility. [1] [2]Enhanced input and focus ring colors in
MiniAppSettings.tsxand icon selector to use theme colors for better focus indication and branding alignment. [1] [2]Updated icon color logic and hover states in
ThemeColorSelector.tsxto utilize theme colors, improving feedback and consistency.Code maintainability:
App-wide theme adoption:
useUIColors, supporting a more cohesive look and easier branding updates across the application. [1] [2] [3] [4] [5] [6] [7]Summary by CodeRabbit