Fix feed fidget settings resetting when switching fidgets

[Jhonattan2121]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved settings editor state management and default value application for better synchronization and consistency
  • Optimized feed refresh performance through refined data effect handling

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
space-system	Ready	Preview, Comment	Jan 2, 2026 7:23am

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes introduce an activation gate mechanism to prevent stale updates in multi-instance FidgetSettingsEditor scenarios, add a default-value merging helper function, and simplify a feed data effect's dependency array by removing settings.

Changes

Cohort / File(s)	Summary
Activation Gate & State Defaults src/common/components/organisms/FidgetSettingsEditor.tsx	Added isActive?: () => boolean optional prop to FidgetSettingsGroup for gating updates. Introduced activeIdRef (useRef) to track the current fidgetId and synchronize state. Created fillWithDefaults helper to merge incoming settings with field defaults. Added safeOnSave guard to skip saves when the editor instance is not active. Updated effect dependencies to include settings, fidgetId, and properties.fields.
Feed Effect Dependencies src/fidgets/farcaster/Feed.tsx	Removed settings from the initial data effect dependency array, narrowing the effect's re-run trigger conditions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A fidget guard I've built with care,
Defaults whisper, fills are fair,
Active refs now keep their place,
No stale saves shall mar the space!
Feed's deps trimmed, lean and bright.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main issue being fixed: preventing feed fidget settings from resetting when switching between fidgets. This aligns with the core changes in FidgetSettingsEditor that introduce an activation gate (isActive function) to guard updates and prevent unwanted state changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

src/common/components/organisms/FidgetSettingsEditor.tsx (3)

181-193: Consider more robust type handling in fillWithDefaults.

The current logic for determining whether a value exists treats all non-string types uniformly (line 190). This means:

• Empty arrays [] or empty objects {} are preserved instead of falling back to defaults
• Boolean false and number 0 are correctly preserved (likely intended)

If field values can be arrays or objects, consider adding specific checks for empty collections, or ensure this behavior is intentional.

🔎 Example: Enhanced type handling

  const fillWithDefaults = (input: FidgetSettings) =>
    properties.fields.reduce((acc, field) => {
      const value =
        input && typeof input === "object"
          ? (input as any)[field.fieldName]
          : undefined;
      const hasValue =
        value !== undefined &&
        value !== null &&
-       (typeof value !== "string" || value.trim() !== "");
+       (typeof value !== "string" || value.trim() !== "") &&
+       (!Array.isArray(value) || value.length > 0) &&
+       (typeof value !== "object" || Object.keys(value).length > 0 || typeof value === "boolean");
      acc[field.fieldName] = hasValue ? value : field.default ?? "";
      return acc;
    }, {} as FidgetSettings);

Note: Adjust based on your field types and intended behavior for empty collections.

---

199-201: Potential unnecessary re-renders from properties.fields dependency.

The effect depends on properties.fields, which could trigger re-renders if the parent component doesn't memoize the properties object. While this doesn't break functionality, it may cause the editor to re-sync state more frequently than necessary.

Consider requesting that parent components memoize the properties prop, or use a deep comparison for properties.fields if this becomes a performance concern.

---

135-136: LGTM! Guards effectively prevent cross-instance state pollution.

The isActive guard at the point of state update ensures that only the currently active editor instance can modify state. The inline callback creates a new function on each render, but the performance impact is negligible for this simple comparison.

Optional: Memoize isActive callback

If you prefer to avoid creating new functions on every render:

+ const isActive = useCallback(
+   () => activeIdRef.current === fidgetId,
+   [fidgetId]
+ );

  <FidgetSettingsGroup
    ...
-   isActive={() => activeIdRef.current === fidgetId}
+   isActive={isActive}
  />

Also applies to: 143-143, 155-155, 264-265, 275-276, 287-288

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0765d93 and 936303f.

📒 Files selected for processing (2)

• src/common/components/organisms/FidgetSettingsEditor.tsx
• src/fidgets/farcaster/Feed.tsx

🧰 Additional context used

🧬 Code graph analysis (1)

src/common/components/organisms/FidgetSettingsEditor.tsx (2)

src/common/fidgets/index.d.ts (1)

• FidgetSettings (15-17)

src/common/lib/hooks/useUIColors.ts (1)

• useUIColors (15-49)

🔇 Additional comments (2)

src/common/components/organisms/FidgetSettingsEditor.tsx (1)

207-219: LGTM! Effective guard mechanism against stale updates.

The safeOnSave wrapper and the guard in _onSave properly prevent updates from inactive editor instances. Combined with fillWithDefaults, this ensures that only the active editor's state—with all defaults applied—is saved to the parent.

src/fidgets/farcaster/Feed.tsx (1)

452-457: LGTM! Correctly removes unnecessary dependency.

The effect body doesn't reference settings, so removing it from the dependency array is correct. This prevents the thread stack from being cleared and the initial hash from being re-pushed when settings change, which aligns with the PR objective of preventing feed settings from resetting when switching fidgets.