MB-59633: Improve performance of Geospatial Search #2268
Conversation
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
There was a problem hiding this comment.
Pull request overview
This PR optimizes performance for geo-spatial queries by addressing heap allocation bottlenecks. The key objective is to reduce allocations in hot paths during document filtering and geo-spatial calculations.
- Reuses DocumentMatch objects in FilteringSearcher to prevent pool exhaustion
- Extracts DocValues visitor closures out of per-document loops to eliminate repeated closure allocations
- Optimizes slice filtering in snapshot_index.go to avoid unnecessary allocations
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| search/searcher/search_filter.go | Adds DocumentMatchPool.Put() calls to recycle rejected document matches, preventing pool exhaustion |
| search/searcher/search_geoshape.go | Moves dvVisitor closure outside the filter function loop to avoid per-document allocations; adds early exit optimization |
| search/searcher/search_geopolygon.go | Extracts dvVisitor and rayIntersectsSegment closures outside the filter function to eliminate repeated allocations |
| search/searcher/search_geopointdistance.go | Moves dvVisitor closure outside filter function and removes unused field parameter |
| search/searcher/search_geoboundingbox.go | Extracts dvVisitor closure outside filter function and removes unused field parameter |
| search/query/boolean.go | Adds DocumentMatchPool.Put() call to recycle refDoc when behind current document |
| index/scorch/snapshot_index.go | Optimizes slice filtering to use in-place mutation instead of allocating new slices; adds fast path for empty updatedFields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CascadingRadium
changed the title
CascadingRadium
changed the title
CascadingRadium
changed the title
DocumentMatchobjects inFilteringSearcherto avoid triggeringDocumentMatchPoolTooSmallwhen documents fail the filter function and are not recycled, which previously caused repeatedDocumentMatchallocations.DocValueVisitorclosure out of the hot path to avoid per-document heap allocations caused by closure escape; the closure is now allocated once and reused, eliminatingruntime.newobjectcalls in the critical loop.DocValuesVisitor.GeoDistanceby avoiding unnecessary string and slice creation and by reusing byte buffers.