Skip to content

Conversation

@CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Jul 7, 2025

  • Adds a NestedDocument interface which extends the Document interface, allowing users to visit any sub-documents that may be nested within the parent document.
  • Adds a new NewIndexInternalID method to create an IndexInternalID and also extends the API to enable getting the integer value of the IndexInternalID from it.
  • Extends the IndexReader interface to support the Ancestors method, which allows the user to fetch the ancestry chain of any document ID given. If the document does not have any ancestors (it is a root document), an ancestry chain containing only the input document is returned.

@CascadingRadium CascadingRadium marked this pull request as draft July 7, 2025 19:26
@CascadingRadium CascadingRadium marked this pull request as ready for review September 13, 2025 14:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for nested document structures by adding new interfaces and methods for handling hierarchical relationships between documents. The changes enable segments to expose ancestor and descendant document relationships while maintaining backward compatibility with flat segments.

Key changes:

  • Added NestedReader interface with Ancestors method for retrieving parent documents
  • Introduced NestedDocument interface for documents containing other documents
  • Added utility methods for IndexInternalID conversion and manipulation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
index.go Adds NestedReader interface, IndexInternalID utility methods, and imports for binary encoding
document.go Introduces NestedDocument interface for hierarchical document structures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CascadingRadium CascadingRadium changed the title MB-27666: Nested Fields [v17] MB-27666: Nested Fields Nov 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CascadingRadium and others added 2 commits December 2, 2025 15:15
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
abhinavdangeti
abhinavdangeti previously approved these changes Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants