[v17] Change FieldIndexingOptions type from int to uint64 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
added a commit
to blevesearch/zapx
that referenced
this pull request
Nov 21, 2025
- Introduces fieldsOptions in the zap file segment to store indexing options for every field. - Decouples indexing logic from Bleve, allowing zapx to independently understand each field’s indexing configuration. - Enables the merger to identify which options were used to index a field without consulting the index mapping. - Adds metadata to the zap file format, making it a breaking change for version 17. - Requires blevesearch/bleve_index_api#76 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
abhinavdangeti
left a comment
abhinavdangeti
left a comment
There was a problem hiding this comment.
Why is this necessary?
CascadingRadium
added a commit
to blevesearch/zapx
that referenced
this pull request
Dec 16, 2025
- Introduces fieldsOptions in the zap file segment to store indexing options for every field. - Decouples indexing logic from Bleve, allowing zapx to independently understand each field’s indexing configuration. - Enables the merger to identify which options were used to index a field without consulting the index mapping. - Adds metadata to the zap file format, making it a breaking change for version 17. - Requires blevesearch/bleve_index_api#76 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
Hi @abhinavdangeti, since v17 we persist FieldIndexingOptions in the segment and varint-encode it, so the type must have a stable, architecture-independent size. In Go, int is platform dependent (32-bit vs 64-bit), which would make the on-disk representation unsafe. Using uint64 guarantees a fixed layout, makes the bitmask intent explicit, and effectively gives us up to 64 flags (instead of potentially 32), allowing future options without changing the storage format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inttouint64for platform independent behaviour.