Add helper methods to work with IndexInternalID
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox and
maneuvertomars
CascadingRadium
changed the title
IndexInternalIIDIndexInternalID
There was a problem hiding this comment.
Pull request overview
This PR adds helper methods for working with IndexInternalID by moving constructor logic from the bleve package into bleve_index_api to keep the API self-contained. It also fixes a spelling error in the type comment.
- Adds
NewIndexInternalIDto encode uint64 values into 8-byte big-endian IDs with buffer reuse - Adds
NewIndexInternalIDFromto copy IDs with buffer reuse - Adds
Valuemethod to decode the uint64 from an ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexInternalIDis defined inbleve_index_api, but its constructors previously lived inbleve.To keep the API self-contained and consistent, this change adds:
NewIndexInternalID— encodes a uint64 into an 8-byte big-endian IndexInternalID, reusing a provided buffer when possible.NewIndexInternalIDFrom— constructs a new IndexInternalID by copying from another, also reusing a provided buffer when possible.Value— decodes and returns the uint64 stored in the ID.This improves API cleanliness and keeps IndexInternalID construction and access logic in one place.