MB-69881: Re-architect vector search #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
There was a problem hiding this comment.
Pull request overview
This pull request refactors vector search to use an iterator-based abstraction for accessing eligible documents, replacing the previous slice-based approach. The changes introduce two new interfaces (EligibleDocumentIterator and EligibleDocumentList) and modify the EligibleDocumentSelector interface to support streaming access patterns, eliminating the need for intermediate materialization of eligible document IDs.
Key Changes:
- Introduced
EligibleDocumentIteratorinterface for streaming document ID iteration - Introduced
EligibleDocumentListinterface as a container providing both iterator access and count information - Modified
EligibleDocumentSelector.SegmentEligibleDocs()to returnEligibleDocumentListinstead of[]uint64
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EligibleDocumentList / EligibleDocumentIterator), enabling storage-layer streaming/visitor-style consumption of eligible docIDs, eliminating intermediate materialization, and decoupling retrieval from underlying eligible-document storage representations.