Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b912de3cfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Release v0.9.2 housekeeping updates to improve module metadata (updatable help) consistency and make the release pipeline more reliable when validating/publishing module manifests.
Changes:
- Move
HelpInfoUrito the top-level of multiple module manifests (and remove it fromPrivateData.PSData). - Minor PowerShell style tweak in
IdLE.Init.ps1(Write-Verbose -Message). - Update release workflow to prepend the staged modules directory to
PSModulePathbeforeTest-ModuleManifest/Publish-Module.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/IdLE/IdLE.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE/IdLE.Init.ps1 |
Uses explicit -Message parameter for Write-Verbose. |
src/IdLE.Steps.Mailbox/IdLE.Steps.Mailbox.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Steps.DirectorySync/IdLE.Steps.DirectorySync.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Steps.Common/IdLE.Steps.Common.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Provider.Mock/IdLE.Provider.Mock.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Provider.ExchangeOnline/IdLE.Provider.ExchangeOnline.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Provider.EntraID/IdLE.Provider.EntraID.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Provider.DirectorySync.EntraConnect/IdLE.Provider.DirectorySync.EntraConnect.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
src/IdLE.Provider.AD/IdLE.Provider.AD.psd1 |
Adds top-level HelpInfoUri and removes it from PSData. |
.github/workflows/release.yml |
Ensures staged modules are discoverable via PSModulePath during manifest validation and publishing. |
|
@blindzero I've opened a new pull request, #148, to work on those changes. Once the pull request is ready, I'll request review from you. |
Restore original PSModulePath before install/import verification to ensure Import-Module resolves the installed package from LocalRepo, not the staged build output from artifacts/modules. This fixes the validation gate to properly catch broken or missing dependency wiring in published packages. Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Scope PSModulePath modification to publish phase in release workflow
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/IdLE.Core/IdLE.Core.psd1:32
HelpInfoUriwas removed from the manifest but not re-added at the top level (unlike the other modules updated in this PR). IfIdLE.Coreshould participate in updatable help, addHelpInfoUri = 'https://blindzero.github.io/IdentityLifecycleEngine/'at the manifest root; otherwise, it would be good to document whyIdLE.Coreis intentionally excluded.
PrivateData = @{
PSData = @{
Tags = @('IdentityLifecycleEngine', 'IdLE', 'Core', 'Engine', 'Workflow', 'Plan', 'Execution', 'Validation')
LicenseUri = 'https://www.apache.org/licenses/LICENSE-2.0'
ProjectUri = 'https://github.com/blindzero/IdentityLifecycleEngine'
ReleaseNotes = 'https://github.com/blindzero/IdentityLifecycleEngine/releases'
ContactEmail = '13959569+blindzero@users.noreply.github.com'
RepositoryUrl = 'https://github.com/blindzero/IdentityLifecycleEngine'
BugTrackerUrl = 'https://github.com/blindzero/IdentityLifecycleEngine/issues'
}
Release v0.9.2