Conversation
blindzero
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR hardens the release pipeline by adding safety gates to prevent broken releases and documents the updated process for maintainers. The changes address a real scenario where a tag version mismatched the module manifest versions.
Changes:
- Added three safety gates to the release workflow: tag must point to main HEAD, CI must be green for the commit, and tag version must match module manifests
- Updated release documentation to describe the new workflow safety gates
- Updated version examples in documentation from 0.7.x to 1.2.x pattern
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added permission for actions API, implemented three safety gate checks (main HEAD validation, CI status validation, version matching), downgraded GitHub Actions from v6 to v4 |
| docs/advanced/releases.md | Added new section documenting release workflow safety gates, updated all version examples from 0.7.x to 1.2.x for consistency |
| docs/index.md | Removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72073664dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…0 runs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…itHub-Release' of https://github.com/blindzero/IdentityLifecycleEngine into issues/14-Guarded-publish-to-PowerShell-Gallery-after-GitHub-Release
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@blindzero I've opened a new pull request, #64, to work on those changes. Once the pull request is ready, I'll request review from you. |
[WIP] Update release pipeline with safety gates and documentation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blindzero
deleted the
issues/14-Guarded-publish-to-PowerShell-Gallery-after-GitHub-Release
branch
Summary
Hardens the release pipeline to prevent broken releases and documents the final maintainer process.
Changes
mainHEADci.yml) is not green for the tag commit SHAWhy
We observed a real mismatch scenario (tag
v0.7.xwhile manifests still at0.7.(x-1)), which could create invalid GitHub Releases or publish the wrong version. These checks make the process robust and less error-prone.Verification
Closes #14