Conversation
…ignment operators
…Context", "EventBuffer" and "RedactionMarker"
…d and PSSA finding solved
blindzero
added this to the
v0.8.0 - Real Providers I (AD + EntraID + EntraID-Sync) milestone
There was a problem hiding this comment.
Pull request overview
This pull request reduces PowerShell Script Analyzer (PSSA) warnings through code formatting improvements, targeted warning suppressions, and enhanced diagnostic logging.
Changes:
- Normalized indentation and spacing to comply with PSSA style rules
- Added PSSA suppressions for false positives (unused parameters used in closures/nested functions)
- Enhanced diagnostic verbosity by adding Write-Verbose calls for intentional error handling
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Set-IdleModuleVersion.ps1 | Collapsed multi-line if-else to single line |
| tools/Generate-IdleStepReference.ps1 | Normalized indentation and updated string formatting for markdown metadata fields |
| tools/Generate-IdleCmdletReference.ps1 | Collapsed assignment and added verbose logging for missing help |
| src/IdLE/IdLE.psm1 | Added verbose logging for module import fallback paths |
| src/IdLE.Core/Public/New-IdlePlanObject.ps1 | Added space after comma in MemberType parameter |
| src/IdLE.Core/Public/Invoke-IdlePlanObject.ps1 | Reformatted EventSink.WriteEvent calls to multi-line style |
| src/IdLE.Core/Private/Write-IdleEvent.ps1 | Aligned variable assignment indentation |
| src/IdLE.Core/Private/Test-IdleCondition.ps1 | Added PSSA suppression for Context parameter used in nested functions |
| src/IdLE.Core/Private/New-IdleEventSink.ps1 | Added PSSA suppression for EventBuffer parameter used in closure |
| src/IdLE.Core/Private/Invoke-IdleWithRetry.ps1 | Enhanced error handling comment and added verbose logging |
| src/IdLE.Core/Private/Copy-IdleRedactedObject.ps1 | Added PSSA suppression for RedactionMarker parameter used in nested functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Reduce ScriptAnalyzer warnings and tighten diagnostics.
Motivation
Reduce PSSA noise while keeping behavior deterministic and diagnosable (Closes #78).
Type of Change
Please select the relevant option:
Changes
Testing
Describe how this change was tested.
How to test & review
Checklist
Related Issues
Closes #78