chore: upgrade bundler to 2.6.9. #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of bundler includes some internal refactorings that broke our monorepo setup. To stay compatible, I've had to rework our `gem` override to instead override `add_dependency`. I believe this is the root of the problem I reported to dependabot: dependabot/dependabot-core#12426 The latest dependabot uses Bundler 2.6.9, and this was causing the issues reported in that ticket since our `gem` override was no longer effective. The specific bundler change prompting this is this PR: ruby/rubygems#8480 In that PR, the `gemspec` method was refactored to no longer call `gem`. Instead, it calls a new `add_dependency` method.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of bundler includes some internal refactorings that broke our monorepo setup. To stay compatible, I've had to rework our
gemoverride to instead overrideadd_dependency.I believe this is the root of the problem I reported to dependabot:
dependabot/dependabot-core#12426
The latest dependabot uses Bundler 2.6.9, and this was causing the issues reported in that ticket since our
gemoverride was no longer effective.The specific bundler change prompting this is this PR:
ruby/rubygems#8480
In that PR, the
gemspecmethod was refactored to no longer callgem. Instead, it calls a newadd_dependencymethod.