chore: rework Gemfiles again. #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts "chore: rework Gemfiles. (#645)" (cce2474). It recombines the root `Gemfile` with `config/Gemfile-for-gem`, doing away with `Gemfile-shared`, while keeping the changes to #645 that impact how the root bundle works (e.g. calling `gem` with each ElasticGraph gem, rather than `gemspec`). This appears to be necessary for dependabot. While some dependabot runs have been successful since #645 was merged, the last few runs have failed with: ``` Handled error whilst updating rubocop-rake: dependency_file_not_supported {message: "{\"errors\":[{\"status\":400,\"title\":\"Bad Request\",\"detail\":\"The request contains invalid or unauthorized changes\"}]}"} ``` I think the problem is `Gemfile-shared`: it's non standard to put gem versions there, and dependabot seems to not like it. By reverting back to a single root `Gemfile` I'm hopeful it'll fix dependabot. In addition, I've reapplied "Increase the dependabot open-pull-request-limit. (#657)", effectively reverting (#659). That was a prior attempt at fixing dependabot which didn't work.
|
|
ayousufi
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts "chore: rework Gemfiles. (#645)" (cce2474). It recombines the root
Gemfilewithconfig/Gemfile-for-gem, doing away withGemfile-shared, while keeping the changes to #645 that impact how the root bundle works (e.g. callinggemwith each ElasticGraph gem, rather thangemspec).This appears to be necessary for dependabot. While some dependabot runs have been successful since #645 was merged, the last few runs have failed with:
I think the problem is
Gemfile-shared: it's non standard to put gem versions there, and dependabot seems to not like it. By reverting back to a single rootGemfileI'm hopeful it'll fix dependabot.In addition, I've reapplied "Increase the dependabot open-pull-request-limit. (#657)", effectively reverting (#659). That was a prior attempt at fixing dependabot which didn't work.