Skip to content
This repository was archived by the owner on Aug 17, 2025. It is now read-only.

fix: validate schema for refs with invalid visibility#5314

Merged
matt2e merged 4 commits intomainfrom
matt2e/ftl-126-schema-validation-should-check-for-invalid-refs-due-to
May 2, 2025
Merged

fix: validate schema for refs with invalid visibility#5314
matt2e merged 4 commits intomainfrom
matt2e/ftl-126-schema-validation-should-check-for-invalid-refs-due-to

Conversation

@matt2e
Copy link
Copy Markdown
Collaborator

@matt2e matt2e commented May 2, 2025

fixes #5313

@matt2e matt2e requested review from a team and alecthomas as code owners May 2, 2025 00:17
@alecthomas alecthomas mentioned this pull request May 2, 2025
@matt2e matt2e requested a review from jvmakine May 2, 2025 00:20
@stuartwdouglas
Copy link
Copy Markdown
Collaborator

I think this failure is due to an existing problem in the JVM runtime with it not exporting decls used in other decls.

@stuartwdouglas
Copy link
Copy Markdown
Collaborator

Hopefully #5246 will fix the issue

@matt2e
Copy link
Copy Markdown
Collaborator Author

matt2e commented May 2, 2025

@stuartwdouglas yep great to fix the JVM issue 👍
I think schema validation should check it regardless, rather than rely on each language always producing valid schema. But also yeh theres the export realm case which can't be fixed by transitive exports as they can cross module boundaries.

@matt2e
Copy link
Copy Markdown
Collaborator Author

matt2e commented May 2, 2025

Blocked by #5315

@stuartwdouglas
Copy link
Copy Markdown
Collaborator

That other PR has issues unrelated to the visbillity, so I have broken out the changes into #5316

@stuartwdouglas stuartwdouglas force-pushed the matt2e/ftl-126-schema-validation-should-check-for-invalid-refs-due-to branch from 659e6e5 to 08a9801 Compare May 2, 2025 01:07
@matt2e matt2e force-pushed the matt2e/ftl-126-schema-validation-should-check-for-invalid-refs-due-to branch from 08a9801 to e0d1fe1 Compare May 2, 2025 03:25
@matt2e matt2e enabled auto-merge (squash) May 2, 2025 03:39
@matt2e matt2e merged commit e1510fa into main May 2, 2025
75 checks passed
@matt2e matt2e deleted the matt2e/ftl-126-schema-validation-should-check-for-invalid-refs-due-to branch May 2, 2025 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema validation should check for invalid refs due to visibility

3 participants