This repository was archived by the owner on Aug 17, 2025. It is now read-only.
Merged
Conversation
This avoids a data race in the schema service
Closed
matt2e
approved these changes
May 2, 2025
alecthomas
reviewed
May 2, 2025
| // WithBuiltins returns a new schema with the builtins module added to each internal realm. | ||
| func (s *Schema) WithBuiltins() *Schema { | ||
| c := new(Schema) | ||
| *c = *s |
Collaborator
There was a problem hiding this comment.
This is not going to be an actual copy right? You'll have to use internal/reflect.DeepCopy() if that's your intent here.
Contributor
Author
There was a problem hiding this comment.
No, this is a shallow copy on purpose. No need for deep copy here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a data race in the schema service