This repository was archived by the owner on Aug 17, 2025. It is now read-only.
feat: Fixed realm name for kube deployments#5333
Merged
stuartwdouglas merged 3 commits intomainfrom May 5, 2025
Merged
Conversation
stuartwdouglas
force-pushed
the
stuartwdouglas/fixed-realm-name
branch
from
2925177 to
aff2815
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/fixed-realm-name
branch
from
aff2815 to
b91ef78
Compare
jvmakine
reviewed
May 4, 2025
| ChangesetEvents []*DeploymentRuntimeEvent `protobuf:"3"` | ||
| DeploymentEvents []*DeploymentRuntimeEvent `protobuf:"4"` | ||
| Realms []*RealmState `protobuf:"5"` | ||
| InternalRealm string `protobuf:"6"` |
Contributor
There was a problem hiding this comment.
I would prefer inferring this from existing Realms. I feel that would make this more flexible, if we ever want to support multiple internal realms in the future.
jvmakine
approved these changes
May 4, 2025
stuartwdouglas
force-pushed
the
stuartwdouglas/fixed-realm-name
branch
from
6ea6281 to
25877b7
Compare
Closed
stuartwdouglas
force-pushed
the
stuartwdouglas/fixed-realm-name
branch
5 times, most recently
from
109f877 to
3ec936b
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/fixed-realm-name
branch
from
3ec936b to
c334213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.