This repository was archived by the owner on Aug 17, 2025. It is now read-only.
chore: ensure leading prefix of stack trace paths is stripped#5338
Merged
alecthomas merged 1 commit intomainfrom May 5, 2025
Merged
chore: ensure leading prefix of stack trace paths is stripped#5338alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
Closed
alecthomas
force-pushed
the
aat/shorter-stack-traces
branch
from
c7c16aa to
ac216e2
Compare
The alecthomas/errors package attempts to reduce the size of paths by stripping the main package, but this requires that all Go binaries are built with "-trimpath". This has been added to the Hermit environment as a default compile flag. Before: > /Users/aat/dev/ftl/go-runtime/ftl/ftltest/ftltest.go:379: /Users/aat/dev/ftl/go-runtime/ftl/ftltest/ftltest.go:434: test harness failed to call verb mysql.insert: /Users/aat/dev/ftl/internal/deploymentcontext/module_context.go:360: /Users/aat/dev/ftl/go-runtime/ftl/ftltest/ftltest.go:450: /Users/aat/dev/ftl/go-runtime/server/server.go:153: /Users/aat/dev/ftl/common/reflection/verb.go:87: /Users/aat/dev/ftl/go-runtime/server/server.go:187: /Users/aat/dev/ftl/go-runtime/server/server.go:232: mysql.createRequest: /Users/aat/dev/ftl/internal/deploymentcontext/module_context.go:360: /Users/aat/dev/ftl/go-runtime/server/server.go:339: /Users/aat/dev/ftl/go-runtime/server/server.go:153: /Users/aat/dev/ftl/common/reflection/verb.go:87: /Users/aat/dev/ftl/go-runtime/server/query.go:116: /Users/aat/dev/ftl/go-runtime/server/query/client.go:100: /Users/aat/dev/ftl/go-runtime/server/query/client.go:136: failed to execute query: /Users/aat/dev/ftl/go-runtime/server/query/client.go:201: failed to execute query: /Users/aat/dev/ftl/backend/runner/query/service.go:119: /Users/aat/dev/ftl/backend/runner/query/service.go:146: not_found: database connection for testdb not found After: > go-runtime/ftl/ftltest/ftltest.go:379: go-runtime/ftl/ftltest/ftltest.go:434: test harness failed to call verb mysql.insert: internal/deploymentcontext/module_context.go:360: go-runtime/ftl/ftltest/ftltest.go:450: go-runtime/server/server.go:153: common/reflection/verb.go:87: go-runtime/server/server.go:187: go-runtime/server/server.go:232: mysql.createRequest: internal/deploymentcontext/module_context.go:360: go-runtime/server/server.go:339: go-runtime/server/server.go:153: common/reflection/verb.go:87: go-runtime/server/query.go:116: go-runtime/server/query/client.go:100: go-runtime/server/query/client.go:136: failed to execute query: go-runtime/server/query/client.go:201: failed to execute query: backend/runner/query/service.go:119: backend/runner/query/service.go:146: not_found: database connection for testdb not found
alecthomas
force-pushed
the
aat/shorter-stack-traces
branch
from
ac216e2 to
5dc58bf
Compare
Collaborator
|
Nice! Much better :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alecthomas/errors package attempts to reduce the size of paths by stripping the main package, but this requires that all Go binaries are built with "-trimpath". This has been added to the Hermit environment as a default compile flag.
Also added a test for ZipRelativeToCaller.
Before:
After: