This repository was archived by the owner on Aug 17, 2025. It is now read-only.
chore: make it more difficult to construct invalid schema "root" objects#5349
Merged
alecthomas merged 3 commits intomainfrom May 5, 2025
Merged
chore: make it more difficult to construct invalid schema "root" objects#5349alecthomas merged 3 commits intomainfrom
alecthomas merged 3 commits intomainfrom
Conversation
Closed
alecthomas
force-pushed
the
aat/schema-builder
branch
from
38f176a to
34153ec
Compare
Where "root" objects are Schema, Realm and Module. This works by: 1. Enabling linting for non-exhaustive manual construction of these types. 2. Adding builders that validate on build.
It is too big of a task, the linter will let us do it incrementally.
alecthomas
force-pushed
the
aat/schema-builder
branch
from
34153ec to
b0aa33b
Compare
alecthomas
force-pushed
the
aat/schema-builder
branch
from
b0aa33b to
691abbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where "root" objects are Schema, Realm and Module.
This works by:
Migrating existing usages to the builders was incredibly fiddly, so instead I've opted to rely on the incremental linting to catch future issues.
All cases can be discovered with: