Skip to content
This repository was archived by the owner on Aug 17, 2025. It is now read-only.

fix: make schema position filenames relative to project root#5351

Merged
worstell merged 1 commit intomainfrom
worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions
May 5, 2025
Merged

fix: make schema position filenames relative to project root#5351
worstell merged 1 commit intomainfrom
worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions

Conversation

@worstell
Copy link
Copy Markdown
Contributor

@worstell worstell commented May 5, 2025

No description provided.

@worstell worstell requested review from a team and alecthomas as code owners May 5, 2025 19:20
@worstell worstell requested a review from wesbillman May 5, 2025 19:20
@alecthomas alecthomas mentioned this pull request May 5, 2025
@worstell worstell force-pushed the worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions branch from 80e7701 to a9a1dbc Compare May 5, 2025 19:28
Copy link
Copy Markdown
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!


extractorRegistery = xsync.NewMapOf[reflect.Type, ExtractDeclFunc[schema.Decl, ast.Node]]()

ProjectRootFlagName = "project_root"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This we still need this to be public? or did the other change fix the issue?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gets used in the schema package in extract.go

@worstell worstell force-pushed the worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions branch from a9a1dbc to 4835857 Compare May 5, 2025 20:18
@worstell worstell enabled auto-merge (squash) May 5, 2025 20:21
@worstell worstell force-pushed the worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions branch from 4835857 to f6f4f9e Compare May 5, 2025 20:24
@worstell worstell merged commit a82402c into main May 5, 2025
76 checks passed
@worstell worstell deleted the worstell/ftl-140-make-paths-relative-to-project-root-in-schema-positions branch May 5, 2025 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants