Merged
Conversation
.github/workflows/license-check.yml
Outdated
| run: | | ||
| python .github/workflows/scripts/check_licenses.py \ | ||
| pyproject.toml || exit_code=$? | ||
| if [ "${exit_code:-0}" -eq 1 ]; then |
Collaborator
There was a problem hiding this comment.
Shall we use the condition of "the exit code is not 0" just in case the script returns some error with exit code other than 1? also set the default value to 1 if exit_code does not exist
eg. if [ "${exit_code:-1}" -ne 0 ]
lifeizhou-ap
approved these changes
Oct 24, 2024
Collaborator
lifeizhou-ap
left a comment
lifeizhou-ap
left a comment
There was a problem hiding this comment.
Nice one!
I added a comment above about checking the script result so that this check won't pass if the script itself fails
feedback
.github/workflows/license-check.yml
Outdated
| run: | | ||
| python .github/workflows/scripts/check_licenses.py \ | ||
| packages/exchange/pyproject.toml || exit_code=$? | ||
| if [ "${exit_code:-0}" -eq 1 ]; then |
Collaborator
There was a problem hiding this comment.
Hi @michaelneale sorry I did not notice we check the exchange licences here. maybe change here too.
also one small thing about ${exit_code:-0}, shall we change to ${exit_code:-1}? in this case, if the exit_code does not exist, we won't treat it as licence check passing.
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will check that licensed of dependencies brought in are valid