chore: remove vector search tool selection strategy by wendytang · Pull Request #3933 · block/goose

wendytang · 2025-08-07T21:26:26Z

clean up - vector strategy no longer used
keeps llm strategy of tool router
removes lancedb dependency as not needed

github-actions · 2025-08-07T21:29:17Z

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-08-18 03:58 UTC

DOsinga

Thanks for doing this! I'll have a closer look later, but two things to consider:

I think we should drop the whole notion of a tool selection strategy. If we have a default strategy which is just to do what the user said and an LLM one that does something smarter, we should turn it into a boolean it feels like. Smart tool selection enabled or not.
Can you update the dependencies? One of the reason we want this out is that it causes binary size bloat.

DOsinga

Thanks for doing this! I'll have a closer look later, but two things to consider:

I think we should drop the whole notion of a tool selection strategy. If we have a default strategy which is just to do what the user said and an LLM one that does something smarter, we should turn it into a boolean it feels like. Smart tool selection enabled or not.
Can you update the dependencies? One of the reason we want this out is that it causes binary size bloat.

crates/goose/src/agents/router_tool_selector.rs

crates/goose/src/providers/openrouter.rs

michaelneale · 2025-08-11T03:25:57Z

@wendytang looks good - like @DOsinga can we get rid of lancedb dep now?

Secondly, seems un unrelated change to openrouter?

* main: add missing dependencies for developer setup (#3930) blog: subagents workshop (#3993) Adding better deeplink support for streamable-http (#3986) Docs: Add Kiwi Flight Search Extension Tutorial (#3985) Revert "Fix file extension on signed osx release (#3974)" Fix file extension on signed osx release (#3974) Dagger container-use MCP (#3932) Add Sunno Song Generator To Recipe Cookbook (#3969) docs: update jetbrains tutorial (#3971) chore: update linux build - don't run on every PR (#3961)

michaelneale · 2025-08-11T05:55:21Z

I like this!

@DOsinga well this removes a bit of weight which isn't needed (lancedb is probably good to speed things up at least in compile times?).

@wendytang not sure about that openrouter change, but otherwise probably pretty good to tidy this up if we do want to get away from this strategy totally (and then simplify?).

crates/goose-cli/src/commands/configure.rs

wendytang · 2025-08-11T19:51:41Z

simple enable/disable

* main: fix: enable 'goose://' handler for debian systems (#3952) fit: default ollama port (#4001) Remove cognitive complexity clippy lint (#4010)

michaelneale

nice one @wendytang seems to work well (tried it on CLI and showed up in GUI).

@DOsinga I think we can get this one in - it does change some env var names (your favourite thing) but that is ok, I don't think anyone depends on them in this case and even if so, no choice.

michaelneale · 2025-08-13T02:22:54Z

ugh sorry @wendytang some colliding changes landed, any chance can take another look?

* main: (21 commits) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) fix: hide console window for stdio extensions on Windows (#4085) Do not fetch pricing information if GOOSE_CLI_SHOW_COST is false (#3901) blog: fixing links (#4089) Token counting reliability + summarization integration. (#3721) Skip ci builds for docs (#4087) blog: agent coordination patterns (#4086) docs: Blog - How I Used Goose to Rebuild My Website (#4076) docs: custom context file names (#4077) Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075) Load recipe deeplinks in single window when app is closed (#4048) docs: make accurate the comments with links to unsigned builds of the app (#4070) ...

michaelneale · 2025-08-15T05:01:07Z

ok I have tried for a few hours to make this work with gpt-5, and to no avail. I really don't follow the logic in RouterToolSelector and it is clear it only partially works, but then it isnt' a change from before.

I am pro getting rid of the old code, so maybe this is ok, and leave that battle for another day?

crates/goose/src/agents/router_tool_selector.rs

crates/goose/src/agents/tool_route_manager.rs

michaelneale · 2025-08-15T05:09:24Z

hrm nope:

─── llm_search | router ──────────────────────────
extension_name: developer
query: [REDACTED: 112 chars]
k: 5

### I can’t access your files yet

I don’t currently have a filesystem tool enabled, so I can’t list the directory contents from here. To let me do that, please add/enable a developer/filesystem extension (e.g., a tool that can run “list directory” or “ls/dir”). Once it’s enabled, I can run it for you.

In the meantime, you can run one of these locally and paste the output:

- macOS/Linux:
  - `pwd`
  - `ls -la`
- Windows (Command Prompt or PowerShell):
  - `cd`
  - `dir`

with gpt-5 - so yeah, really doesn't work that well.

I agree with the cleanup but I don't think the router tool selection strategy is workable either.

angiejones · 2025-08-18T02:04:18Z

good to merge!

…ol-visibility * origin/main: (26 commits) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) feat(mcp): Persist OAuth credentials to keyring (#4007) Sanitize Tags Unicode Block at prompt level (#4047) Fixing typos (#4114) chore(release): release version 1.4.0 (#4069) E2E tests working again (#4103) chore: Delete ARCHITECTURE.md (#4108) Add Youtube short to Kiwi MCP tutorial (#4107) docs: fix experimental warning (#4102) fix not being able to add spaces to activity message area (#4055) remove and cleanup unused code (#4074) docs: Add missing references to smart_approve mode. (#4094) quick typo fix pulse blog (#4095) fix: update dictation settings handling and improve user feedback (#4093) chore: add info tooltip to share session button (#4038) Reroute routes (#4088) fix(cli): fix compiling issue on windows system by adding a missing param (#4019) ...

…-messaging * 'main' of github.com:block/goose: (26 commits) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) feat(mcp): Persist OAuth credentials to keyring (#4007) Sanitize Tags Unicode Block at prompt level (#4047) Fixing typos (#4114) chore(release): release version 1.4.0 (#4069) E2E tests working again (#4103) chore: Delete ARCHITECTURE.md (#4108) Add Youtube short to Kiwi MCP tutorial (#4107) ...

…ackages * 'main' of github.com:block/goose: fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) # Conflicts: # ui/desktop/src/components/MarkdownContent.tsx

* main: (67 commits) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) feat(mcp): Persist OAuth credentials to keyring (#4007) Sanitize Tags Unicode Block at prompt level (#4047) Fixing typos (#4114) chore(release): release version 1.4.0 (#4069) ...

…npm-cacheing * 'main' of github.com:block/goose: Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130)

* 'main' of github.com:block/goose: (51 commits) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) ... # Conflicts: # ui/desktop/src/App.test.tsx

Co-authored-by: Michael Neale <michael.neale@gmail.com> Signed-off-by: Jack Wright <jack.wright@nike.com>

joeeuston-dev · 2025-08-23T05:07:33Z

I'm using LLM Strategy with VertexAI -> Claude-Sonnet-4
No issues on 1.3.0.
Now I'm on 1.6.0 and I've noticed My agent doesn't know what subagents are and can't find them. Doing some troubleshooting led me back to this.
Changing my Tool Selection Strategy back to default has unblocked me, but there may be others who still unknowingly have their default tool selection set to LLM and are having issues

Wendy Tang added 2 commits August 7, 2025 14:02

see

a903493

dont update docs, tool selection strategy

d416589

Wendy Tang added 4 commits August 7, 2025 14:32

fmt

285c9d1

Merge branch 'main' into wtang/rm_vector_search

e134387

fmt

c7a0518

have system

3257c32

wendytang requested a review from DOsinga August 8, 2025 20:03

wendytang marked this pull request as ready for review August 8, 2025 20:03

DOsinga reviewed Aug 8, 2025

View reviewed changes

crates/goose/src/agents/router_tool_selector.rs Outdated Show resolved Hide resolved

michaelneale reviewed Aug 11, 2025

View reviewed changes

crates/goose/src/providers/openrouter.rs Show resolved Hide resolved

michaelneale added 2 commits August 11, 2025 15:17

getting rid of un-used dependency

1be3f8e

michaelneale reviewed Aug 11, 2025

View reviewed changes

crates/goose-cli/src/commands/configure.rs Outdated Show resolved Hide resolved

michaelneale self-assigned this Aug 11, 2025

Wendy Tang added 2 commits August 11, 2025 12:31

chore: enable tool router (#4011)

8328799

recipes does not have tool router

11208ae

Wendy Tang and others added 2 commits August 11, 2025 17:02

Merge branch 'main' into wtang/rm_vector_search

24a7206

Merge branch 'main' into wtang/rm_vector_search

c387147

* main: fix: enable 'goose://' handler for debian systems (#3952) fit: default ollama port (#4001) Remove cognitive complexity clippy lint (#4010)

michaelneale requested a review from DOsinga August 12, 2025 03:44

michaelneale approved these changes Aug 12, 2025

View reviewed changes

michaelneale added performance Performance related ready labels Aug 12, 2025

michaelneale assigned DOsinga and unassigned DOsinga Aug 12, 2025

michaelneale added 2 commits August 15, 2025 12:59

clarify when can use llm tool selection

cdc49f6

michaelneale reviewed Aug 15, 2025

View reviewed changes

crates/goose/src/agents/router_tool_selector.rs Show resolved Hide resolved

michaelneale reviewed Aug 15, 2025

View reviewed changes

crates/goose/src/agents/tool_route_manager.rs Show resolved Hide resolved

DOsinga mentioned this pull request Aug 16, 2025

feat: Add tool_vectordb feature to goose crate #4138

Closed

Merge branch 'main' into wtang/rm_vector_search

6ac76a9

michaelneale requested a review from a team as a code owner August 17, 2025 23:51

michaelneale added 2 commits August 18, 2025 10:21

merge whoopsie

1a5b7a7

clarify wording as experimental

17cecdf

michaelneale approved these changes Aug 18, 2025

View reviewed changes

michaelneale added 2 commits August 18, 2025 10:40

lock

a2ba889

signature change

9ed6021

angiejones approved these changes Aug 18, 2025

View reviewed changes

blackgirlbytes approved these changes Aug 18, 2025

View reviewed changes

michaelneale merged commit b235596 into main Aug 18, 2025
12 checks passed

michaelneale deleted the wtang/rm_vector_search branch August 18, 2025 03:56

This was referenced Aug 18, 2025

chore(release): release version 1.5.0 #4154

Closed

chore(release): release version 1.5.0 #4169

Merged

ayax79 pushed a commit to ayax79/goose that referenced this pull request Aug 21, 2025

chore: remove vector search tool selection strategy (block#3933)

86027f5

Co-authored-by: Michael Neale <michael.neale@gmail.com> Signed-off-by: Jack Wright <jack.wright@nike.com>

Comments

Conversation

wendytang commented Aug 7, 2025 • edited by michaelneale Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelneale commented Aug 11, 2025

Uh oh!

michaelneale commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

wendytang commented Aug 11, 2025

Uh oh!

michaelneale left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Aug 13, 2025

Uh oh!

michaelneale commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

michaelneale commented Aug 15, 2025

Uh oh!

angiejones commented Aug 18, 2025

Uh oh!

Uh oh!

joeeuston-dev commented Aug 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wendytang commented Aug 7, 2025 •

edited by michaelneale

Loading

github-actions bot commented Aug 7, 2025 •

edited

Loading

michaelneale commented Aug 11, 2025 •

edited

Loading

michaelneale left a comment •

edited

Loading