Create recipe feedback and initialization, recipe ui and state refactor#4972
Closed
zanesq wants to merge 11 commits intozane/create-recipe-unificationfrom
Closed
Create recipe feedback and initialization, recipe ui and state refactor#4972zanesq wants to merge 11 commits intozane/create-recipe-unificationfrom
zanesq wants to merge 11 commits intozane/create-recipe-unificationfrom
Conversation
…se into zane/create-recipe-unification-feedback * 'zane/create-recipe-unification' of github.com:block/goose: feat(nightly): build nightlies from main shas (#4888) Add missing library for fedora/rhel/centos docs (#4819) feat(process): Add GOVERNANCE and MAINTAINERS documents (#4962) Pause test finder, have it run cargo fmt (#4958) Disable the issue comment trigger on pr-comment-bundle (#4961) fix(providers): update Claude Sonnet 4 model identifier (#4884) fix redirect to extensions page after deeplink install and show toast with success message (#4863) Remove wait-for-ready log (#4956)
…recipe while saving and remove unnecessary optional fields
…se into zane/create-recipe-unification-feedback * 'zane/create-recipe-unification' of github.com:block/goose: Lifei/create save recipe to file (#4895)
Collaborator
Author
|
Closing this so we can get a plan together first will bring over the ui changes to the original PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up for the larger refactor efforts mentioned in feedback on #4693
I had goose analyze my changes to help with my PR description:
Major Architectural Improvements
1. Hook Separation and Specialization
useAgent.ts: Extracted agent initialization logic into a dedicateduseAgentInitialization.tshookuseRecipeManager.ts: Broke down the monolithic recipe manager into three specialized hooks:useRecipeState.ts- Core recipe state management and validationuseRecipeUI.ts- UI-specific interactions and modal handlinguseRecipeCreationModal.ts- Recipe creation modal logicuseAgent.tswent from 257 lines to just 61 lines2. Improved State Management
forceResetand genericresetChatwith targeted reset options:resetSession- Creates new session IDclearMessages- Clears chat messagesclearRecipe- Removes recipe configurationclearRecipeParameters- Clears recipe parameters3. Enhanced Error Handling
NoProviderOrModelErrorAgentInitializationErrorConfigurationError4. Recipe Management Improvements
recipeConfigwithrecipethroughout the codebase for consistency5. UI/UX Enhancements
6. Code Quality Improvements
Key Benefits