Skip to content

Feat: Added custom headers and toggle keyring CLI options#5017

Merged
dianed-square merged 6 commits intoblock:mainfrom
BlairAllan:feat/custom-headers-keyring-config
Dec 1, 2025
Merged

Feat: Added custom headers and toggle keyring CLI options#5017
dianed-square merged 6 commits intoblock:mainfrom
BlairAllan:feat/custom-headers-keyring-config

Conversation

@BlairAllan
Copy link
Contributor

@BlairAllan BlairAllan commented Oct 6, 2025

Summary

Add support for custom HTTP headers and a CLI option to toggle keyring storage. Updated docs to explain how to add these headers and provided an example.

Type of Change

  • Feature

Testing

  • Added unit tests for custom headers in custom_providers.rs to verify that the headers are saved
    and loaded correctly
  • Manually tested the CLI flow for adding custom headers
  • Manually tested the keyring toggle functionality via goose configure > Settings > Secret
    Storage

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch 2 times, most recently from ac9d599 to 564ff96 Compare October 6, 2025 00:12
@taniacryptid
Copy link
Contributor

taniacryptid commented Oct 8, 2025

Let us know when this is ready for review, or if you have questions!

DOsinga
DOsinga approved these changes Oct 11, 2025
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch from 564ff96 to dffd0dd Compare October 20, 2025 19:36
@BlairAllan BlairAllan marked this pull request as ready for review October 20, 2025 19:40
@BlairAllan BlairAllan requested a review from a team as a code owner October 20, 2025 19:40
@BlairAllan BlairAllan changed the title Feature/Added custom headers and toggle keyring CLI options Feat: Added custom headers and toggle keyring CLI options Oct 21, 2025
@BlairAllan BlairAllan requested a review from DOsinga October 21, 2025 06:51
DOsinga
DOsinga approved these changes Oct 21, 2025
View reviewed changes
iandouglas
iandouglas previously requested changes Oct 21, 2025
View reviewed changes
@blackgirlbytes
Copy link
Contributor

blackgirlbytes commented Oct 25, 2025

here's how to fix the DCO check

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch 3 times, most recently from b37fb67 to cbee07e Compare October 25, 2025 11:55
@BlairAllan BlairAllan requested a review from iandouglas October 25, 2025 12:26
@DOsinga
Copy link
Collaborator

DOsinga commented Nov 10, 2025

sorry @BlairAllan for letting this linger - there was a merge conflict I tried to fix, but we changed the interface and I think I made it worse. can you have a look?

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch from c93eead to 4d119b2 Compare November 12, 2025 21:28
@DOsinga
Copy link
Collaborator

DOsinga commented Nov 20, 2025

there's a linter error now @BlairAllan

@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch 7 times, most recently from edbfbe0 to 36d83b8 Compare November 29, 2025 19:17
@BlairAllan
Added custom headers to openai compatible providers and keyring toggle
76ce0f6 
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@BlairAllan
minor changes to docs and comments
047bb95 
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@BlairAllan
added warning if env is set for keyring
8a11fc3 
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@BlairAllan
change error type
ee9bd5c 
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@BlairAllan
fix linting and signoff
a525296 
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@BlairAllan BlairAllan force-pushed the feat/custom-headers-keyring-config branch from 36d83b8 to a525296 Compare November 29, 2025 19:48
@BlairAllan
Copy link
Contributor Author

BlairAllan commented Nov 30, 2025

there's a linter error now @BlairAllan

This should all be fixed now

@angiejones angiejones dismissed iandouglas’s stale review December 1, 2025 03:45

no longer on team

dianed-square
dianed-square reviewed Dec 1, 2025
View reviewed changes
@dianed-square dianed-square merged commit ccaf7ca into block:main Dec 1, 2025
16 checks passed
zanesq added a commit that referenced this pull request Dec 1, 2025
@zanesq
Merge branch 'main' of github.com:block/goose into zane/multichat-demo
46ff842 
* 'main' of github.com:block/goose:
  Feat: Added custom headers and toggle keyring CLI options (#5017)
  Feat/automatic update installation (#5345)
  fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933)
  fix: anthropic provider model fetching (#5932)
  [MCP-UI] add CSP for images to proxy HTML (#5931)
katzdave added a commit that referenced this pull request Dec 1, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/openai-respo…
f45c88a 
…nses-streaming

* 'main' of github.com:block/goose:
  docs: promote planning guide (#5934)
  fix: use a lock to ensure only need to run tunnel just in case multiple go… (#5885)
  Feat: Added custom headers and toggle keyring CLI options (#5017)
zanesq added a commit that referenced this pull request Dec 2, 2025
@zanesq
Merge branch 'main' of github.com:block/goose into integration/pr-495…
d3173be 
…0-5147

* 'main' of github.com:block/goose: (243 commits)
  chore: upgrade npm packages (#5951)
  feat: ActionRequired (#5897)
  feat(acp): support loading sessions in acp (#5942)
  docs: add videos to multi-model page (#5938)
  docs: promote planning guide (#5934)
  fix: use a lock to ensure only need to run tunnel just in case multiple go… (#5885)
  Feat: Added custom headers and toggle keyring CLI options (#5017)
  Feat/automatic update installation (#5345)
  fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933)
  fix: anthropic provider model fetching (#5932)
  [MCP-UI] add CSP for images to proxy HTML (#5931)
  fix: correct typo in blog post (AIMDOEL -> AIMODEL) (#5902)
  feat: @goose in terminal (native terminal support) (#5887)
  docs: adding AI-friendly features (#5918)
  Blog/advent of ai announcement (#5917)
  Extension selector behind ALPHA flag (#5892)
  blog: typo fixes (#5896)
  blog: fixing img url (#5895)
  blog: MCPs for Developers (#5884)
  docs: Extension Manager MCP (#5883)
  ...

# Conflicts:
#	crates/goose-server/src/routes/config_management.rs
#	crates/goose/src/providers/mod.rs
#	ui/desktop/openapi.json
#	ui/desktop/src/api/sdk.gen.ts
#	ui/desktop/src/api/types.gen.ts
#	ui/desktop/src/components/ProgressiveMessageList.tsx
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Merged
@dianed-square dianed-square mentioned this pull request Dec 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

@dianed-square dianed-square dianed-square left review comments

@iandouglas iandouglas Awaiting requested review from iandouglas

Assignees

@DOsinga DOsinga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BlairAllan @taniacryptid @blackgirlbytes @DOsinga @iandouglas @dianed-square

Comments