Test against fastmcp by jamadeo · Pull Request #6666 · block/goose

jamadeo · 2026-01-23T17:04:24Z

I also removed the developer extension test from here because we've switched transport types to run that in-process

Copilot

Pull request overview

This PR updates the MCP replay-based integration test suite to exercise compatibility against a FastMCP server instead of the previous goosed -- mcp developer replay.

Changes:

Replaced the goosed -- mcp developer replay test case with a FastMCP-based replay (uv run --with fastmcp==2.14.4 ...).
Added a minimal FastMCP Python test server (divide tool) plus new replay and expected results fixtures.
Updated Cargo.lock to reflect the current workspace version (1.20.0) for goose-acp.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/goose/tests/mcp_integration_test.rs	Swaps the replayed MCP test case from `goosed` to FastMCP and updates tool calls accordingly.
crates/goose/tests/fastmcp_test_server.py	Adds a small FastMCP server used when recording the replay.
crates/goose/tests/mcp_replays/uvrun--withfastmcp==2.14.4fastmcpruntests_fastmcp_test_server.py	Adds the recorded stdio replay log for the FastMCP server.
crates/goose/tests/mcp_replays/uvrun--withfastmcp==2.14.4fastmcpruntests_fastmcp_test_server.py.results.json	Adds expected tool-call results for the FastMCP replay.
crates/goose/tests/mcp_replays/cargorun--quiet-pgoose-server--bingoosed--mcpdeveloper	Removes the prior `goosed` developer replay log.
crates/goose/tests/mcp_replays/cargorun--quiet-pgoose-server--bingoosed--mcpdeveloper.results.json	Removes the prior expected results for the `goosed` developer replay.
Cargo.lock	Updates lockfile entries to match workspace versioning.

Copilot · 2026-01-23T17:10:20Z

crates/goose/tests/mcp_integration_test.rs

+    vec!["uv", "run", "--with", "fastmcp==2.14.4", "fastmcp", "run", "tests/fastmcp_test_server.py"],
    vec![
-        CallToolRequestParam { name: "text_editor".into(), arguments: Some(object!({
-            "command": "view",
-            "path": "/tmp/goose_test/goose.txt"
-        }))},
-        CallToolRequestParam { name: "text_editor".into(), arguments: Some(object!({
-            "command": "str_replace",
-            "path": "/tmp/goose_test/goose.txt",
-            "old_str": "# goose",
-            "new_str": "# goose (modified by test)"
-        }))},
-        // Test shell command to verify file was modified
-        CallToolRequestParam { name: "shell".into(), arguments: Some(object!({
-            "command": "cat /tmp/goose_test/goose.txt"
-        })) },
-        // Test text_editor tool to restore original content
-        CallToolRequestParam { name: "text_editor".into(), arguments: Some(object!({
-            "command": "str_replace",
-            "path": "/tmp/goose_test/goose.txt",
-            "old_str": "# goose (modified by test)",
-            "new_str": "# goose"
-        }))},
-        CallToolRequestParam { name: "list_windows".into(), arguments: Some(object!({})) },
+        CallToolRequestParam { name: "divide".into(), arguments: Some(object!({
+            "dividend": 10,
+            "divisor": 2
+        })) }


The FastMCP test uses a relative script path ("tests/fastmcp_test_server.py"), but extensions are launched with the test process current_dir (often the workspace root or ./crates in CI), so recording replays will fail to find the script; use an absolute path derived from env!("CARGO_MANIFEST_DIR") (e.g., via concat!) so it works regardless of where cargo test is run from.

Copilot · 2026-01-23T17:10:20Z

crates/goose/tests/mcp_replays/uvrun--withfastmcp==2.14.4fastmcpruntests_fastmcp_test_server.py

@@ -0,0 +1,29 @@
+STDIN: {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"protocolVersion":"2025-03-26","capabilities":{"sampling":{},"elicitation":{}},"clientInfo":{"name":"goose","version":"0.0.0"}}}


leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers (in Python 3).

…apshot-test

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

* origin/main: fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) Test against fastmcp (#6666) docs: mid-session changes (#6672) Fix MCP elicitation deadlock and improve UX (#6650) chore: upgrade to rmcp 0.14.0 (#6674) [docs] add MCP-UI to MCP Apps blog (#6664) ACP get working dir from args.cwd (#6653) Optimise load config in UI (#6662) # Conflicts: # ui/desktop/src/components/Layout/AppLayout.tsx

…o dkatz/canonical-context * 'dkatz/canonical-provider' of github.com:block/goose: (27 commits) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) Test against fastmcp (#6666) docs: mid-session changes (#6672) Fix MCP elicitation deadlock and improve UX (#6650) chore: upgrade to rmcp 0.14.0 (#6674) [docs] add MCP-UI to MCP Apps blog (#6664) ACP get working dir from args.cwd (#6653) Optimise load config in UI (#6662) Fix GCP Vertex AI global endpoint support for Gemini 3 models (#6187) fix: macOS keychain infinite prompt loop (#6620) chore: reduce duplicate or unused cargo deps (#6630) feat: codex subscription support (#6600) smoke test allow pass for flaky providers (#6638) feat: Add built-in skill for goose documentation reference (#6534) Native images (#6619) docs: ml-based prompt injection detection (#6627) Strip the audience for compacting (#6646) chore(release): release version 1.21.0 (minor) (#6634) add collapsable chat nav (#6649) ...

Test against fastmcp

a2c099a

Copilot AI review requested due to automatic review settings January 23, 2026 17:04

Copilot started reviewing on behalf of jamadeo January 23, 2026 17:04 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

alexhancock approved these changes Jan 23, 2026

View reviewed changes

jamadeo added 4 commits January 23, 2026 12:23

Merge remote-tracking branch 'origin/main' into jackamadeo/fastmcp-sn…

248c3fd

…apshot-test

Merge remote-tracking branch 'origin/main' into jackamadeo/fastmcp-sn…

0a0d9c3

…apshot-test

s

69861d0

Update tools and pin server-everything

538b4e7

Copilot AI review requested due to automatic review settings January 23, 2026 20:56

Copilot started reviewing on behalf of jamadeo January 23, 2026 20:57 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

jamadeo merged commit 1bf952e into main Jan 23, 2026
26 checks passed

jamadeo deleted the jackamadeo/fastmcp-snapshot-test branch January 23, 2026 21:11

JulianJvn mentioned this pull request Jan 24, 2026

goose 1.21.0 fails to start MCP server #6663

Closed

This was referenced Jan 27, 2026

chore(release): release version 1.22.0 (minor) #6725

Closed

chore(release): release version 1.22.0 (minor) salmanmkc/goose#1

Open

chore(release): release version 1.22.0 (minor) #6812

Closed

chore(release): release version 1.22.0 (minor) #6813

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test against fastmcp#6666

Test against fastmcp#6666
jamadeo merged 5 commits intomainfrom
jackamadeo/fastmcp-snapshot-test

jamadeo commented Jan 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

		@@ -0,0 +1,29 @@
		STDIN: {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"protocolVersion":"2025-03-26","capabilities":{"sampling":{},"elicitation":{}},"clientInfo":{"name":"goose","version":"0.0.0"}}}

Conversation

jamadeo commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

jamadeo commented Jan 23, 2026 •

edited

Loading