Desktop: - No Custom Headers field for custom OpenAI-compatible providers by Lymah123 · Pull Request #6681 · block/goose

Lymah123 · 2026-01-23T20:35:11Z

Summary

This PR:

Add custom headers section to CustomProviderForm with add/remove/edit functionality
Fix modal scrolling issue by adding max-h and overflow-y-auto to DialogContent
Fix duplicate isFilePickerOpen declaration in ChatInput.tsx
Update auto-generated API client files

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Related Issues

closes #6048
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

Copilot

Pull request overview

This PR adds support for custom HTTP headers to custom OpenAI-compatible providers in the Desktop app, along with UI fixes for modal scrolling and duplicate state declaration.

Changes:

Added custom headers section to CustomProviderForm with validation and add/remove/edit functionality
Fixed modal scrolling by adding max-height and overflow to DialogContent
Removed duplicate isFilePickerOpen state declaration in ChatInput

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
CustomProviderForm.tsx	Added custom headers feature with state management, validation (empty fields, spaces in keys), UI components (input fields, add/remove buttons), and form submission logic
ProviderGrid.tsx	Fixed modal scrolling by adding max-h-[90vh] and overflow-y-auto to DialogContent to handle long forms
ChatInput.tsx	Fixed duplicate isFilePickerOpen declaration by moving it earlier and removing the duplicate; included minor formatting cleanup

Copilot · 2026-01-23T20:37:39Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+  const handleAddHeader = () => {
+    const keyEmpty = !newHeaderKey.trim();
+    const valueEmpty = !newHeaderValue.trim();
+    const keyHasSpaces = newHeaderKey.includes(' ');
+
+    if (keyEmpty || valueEmpty) {
+      setInvalidHeaderFields({
+        key: keyEmpty,
+        value: valueEmpty,
+      });
+      setHeaderValidationError('Both header name and value must be provided');
+      return;
+    }
+
+    if (keyHasSpaces) {
+      setInvalidHeaderFields({
+        key: true,
+        value: false,
+      });
+      setHeaderValidationError('Header name cannot contain spaces');
+      return;
+    }
+
+    setHeaderValidationError(null);
+    setInvalidHeaderFields({ key: false, value: false });
+    setHeaders([...headers, { key: newHeaderKey, value: newHeaderValue }]);
+    setNewHeaderKey('');
+    setNewHeaderValue('');
+  };


The validation doesn't check for duplicate header keys. If a user adds the same header name twice (e.g., "Authorization" twice), both will be accepted but only the last value will be kept when converting to the object format in handleSubmit (lines 136-144). Consider adding a check to prevent duplicate keys.

zanesq · 2026-01-23T20:40:02Z

Thanks, does the goose backend actually use these new header fields in the LLM requests?

Lymah123 · 2026-01-23T20:46:49Z

Thanks, does the goose backend actually use these new header fields in the LLM requests?

Yes, the backend fully supports and uses custom headers. In openai.rs (lines 169-177), the from_custom_config method reads headers from DeclarativeProviderConfig, converts them to a HeaderMap, and adds them to the ApiClient. These headers are then included in all HTTP requests to the custom provider. The UI was simply missing a way to set these headers - the backend has supported them all along.

Moreover, this feature is already in CLI.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

ui/desktop/src/components/settings/providers/ProviderGrid.tsx:207

When editing a provider, the headers field from editingProvider.config.headers is not being passed to the CustomProviderForm. This means existing headers will be lost when editing a provider. Add headers to the initialData object: headers: editingProvider.config.headers ?? null

  const initialData = editingProvider && {
    engine: editingProvider.config.engine,
    display_name: editingProvider.config.display_name,
    api_url: editingProvider.config.base_url,
    api_key: '',
    models: editingProvider.config.models.map((m) => m.name),
    supports_streaming: editingProvider.config.supports_streaming ?? true,
  };

ui/desktop/src/components/ChatInput.tsx:696

Callee is not a function: it has type undefined.

          const compressedDataUrl = await compressImageDataUrl(dataUrl);

ui/desktop/src/components/ChatInput.tsx:1039

Callee is not a function: it has type undefined.

          const compressedDataUrl = await compressImageDataUrl(dataUrl);

Copilot · 2026-01-23T21:07:13Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

      api_key: apiKey,
      models: modelList,
      supports_streaming: supportsStreaming,
+      headers: Object.keys(headersObject).length > 0 ? headersObject : null,


The backend API does not support the 'headers' field in UpdateCustomProviderRequest. Looking at crates/goose-server/src/routes/config_management.rs (lines 82-89), the UpdateCustomProviderRequest struct only includes: engine, display_name, api_url, api_key, models, and supports_streaming. Sending headers will cause the backend to reject this request or silently ignore the field.

The backend must be updated to accept headers before this frontend change can work. The DeclarativeProviderConfig in the backend (crates/goose/src/config/declarative_providers.rs:39) already has support for headers, but the create_custom_provider and update_custom_provider functions do not accept headers as parameters.

@Lymah123 can you review these copilot reviews and resolve or comment?

Copilot · 2026-01-23T21:07:14Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+      if (initialData.headers) {
+        const headerList = Object.entries(initialData.headers).map(([key, value]) => ({
+          key,
+          value,
+        }));
+        setHeaders(headerList);
+      }


The initialData prop is typed as UpdateCustomProviderRequest in the function signature, but UpdateCustomProviderRequest doesn't have a headers field according to types.gen.ts. The code tries to access initialData.headers on line 53, which would cause a TypeScript error. Either UpdateCustomProviderRequest needs to be updated to include headers, or a different type should be used for initialData.

Copilot · 2026-01-23T21:07:14Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+  const handleHeaderChange = (index: number, field: 'key' | 'value', value: string) => {
+    const updatedHeaders = [...headers];
+    updatedHeaders[index][field] = value;
+    setHeaders(updatedHeaders);


Header editing (handleHeaderChange) doesn't validate the changes. Users can edit existing headers to have invalid values (e.g., spaces in key, empty key or value). Consider adding validation when submitting the form, or preventing invalid edits in real-time.

Suggested change

setHeaders(updatedHeaders);

setHeaders(updatedHeaders);

const currentHeader = updatedHeaders[index];

const keyEmpty = !currentHeader.key.trim();

const valueEmpty = !currentHeader.value.trim();

const keyHasSpaces = currentHeader.key.includes(' ');

if (keyEmpty || valueEmpty) {

setInvalidHeaderFields({

key: keyEmpty,

value: valueEmpty,

});

setHeaderValidationError('Both header name and value must be provided');

return;

}

if (keyHasSpaces) {

setInvalidHeaderFields({

key: true,

value: false,

});

setHeaderValidationError('Header name cannot contain spaces');

return;

}

clearHeaderValidation();

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-24T14:53:16Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+                onClick={handleAddHeader}
+                variant="ghost"
+                type="button"
+                className="flex items-center justify-start gap-1 px-2 pr-4 text-sm rounded-full text-textStandard bg-background-default border border-borderSubtle hover:border-borderStandard transition-colors min-w-[60px] h-9 [&>svg]:size-4!"


The Tailwind important modifier syntax is incorrect. The ! should be placed before the property name, not after. Change [&>svg]:size-4! to [&>svg]:!size-4 to match the established pattern used in HeadersSection.tsx.

Suggested change

className="flex items-center justify-start gap-1 px-2 pr-4 text-sm rounded-full text-textStandard bg-background-default border border-borderSubtle hover:border-borderStandard transition-colors min-w-[60px] h-9 [&>svg]:size-4!"

className="flex items-center justify-start gap-1 px-2 pr-4 text-sm rounded-full text-textStandard bg-background-default border border-borderSubtle hover:border-borderStandard transition-colors min-w-[60px] h-9 [&>svg]:!size-4"

Copilot · 2026-01-24T14:53:17Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+        key: keyEmpty,
+        value: valueEmpty,
+      });
+      setHeaderValidationError('Both header name and value must be provided');


The validation error message is inconsistent with the established pattern in HeadersSection.tsx. Change "Both header name and value must be provided" to "Both header name and value must be entered" to maintain consistency across the codebase. (Reference: ui/desktop/src/components/settings/extensions/modal/HeadersSection.tsx:53)

Lymah123 · 2026-01-24T16:53:20Z

The PR is ready for review.

zanesq · 2026-01-27T16:54:48Z

crates/goose/src/config/declarative_providers.rs

            base_url: api_url,
            models: model_infos,
-            headers: existing_config.headers,
+            headers: headers.or(existing_config.headers),


I think this logic means:

If headers is Some(...), use the new headers
If headers is None, keep existing headers

This makes it impossible to clear headers once set. If a user wants to remove all custom headers, passing None will just keep the old ones.

Maybe the UI should distinguish between "not provided" and "explicitly empty"?

change to something like

headers: if headers.is_some() { headers } else { existing_config.headers }, // Or better: always use the provided headers value (including None to clear) headers: headers,

And update the UI to explicitly send {} when user wants no headers.

Alright, I'd do that. Thanks.

zanesq · 2026-01-27T16:55:59Z

crates/goose/src/config/declarative_providers.rs

    Ok(provider_config)
 }

+#[allow(clippy::too_many_arguments)]


The function now has 8 parameters.
Rather than adding the clippy allow maybe create a struct like UpdateCustomProviderParams to group these? This would also make future additions cleaner.

zanesq · 2026-01-27T17:29:53Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

      api_key: apiKey,
      models: modelList,
      supports_streaming: supportsStreaming,
+      headers: Object.keys(headersObject).length > 0 ? headersObject : null,


@Lymah123 can you review these copilot reviews and resolve or comment?

Lymah123 · 2026-01-28T00:31:41Z

Thanks for the feedback and the suggestions @zanesq . I will look into that. Yes, I will resolve the Copilot reviews. I was waiting for human reviews and working on the suggestions together.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

- Added custom headers section to CustomProviderForm.tsx - Fixed modal scrolling issue in ProviderGrid.tsx - Fixed duplicate variable declaration in ChatInput.tsx Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

- Added #[allow(clippy::too_many_arguments)] to update_custom_provider - Resolved all merge conflict markers in ChatInput.tsx Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

- Remove unused StreamableHttpOptions import - Extract URLs from StreamableHttpOptions for parse_cli_flag_extensions - Remove extra blank line for fmt check Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-30T16:41:45Z

crates/goose-server/src/routes/config_management.rs

+    .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;
+>>>>>>> 04269837bc8 (Backend: Add headers parameter to update_custom_provider)


Merge conflict markers left in the code. Line 749 already ends the function call with )?; but lines 750-751 contain a duplicate error handling chain and a merge conflict marker that should be removed.

Suggested change

.map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;

>>>>>>> 04269837bc8 (Backend: Add headers parameter to update_custom_provider)

Copilot · 2026-01-30T16:41:45Z

crates/goose-cli/src/session/builder.rs

+    let streamable_urls: Vec<String> = session_config
+        .streamable_http_extensions
+        .iter()
+        .map(|opt| opt.url.clone())
+        .collect();
+
    let cli_flag_extensions_to_load = parse_cli_flag_extensions(
        &session_config.extensions,
-        &session_config.streamable_http_extensions,
+        &streamable_urls,


Type mismatch in function call. The function parse_cli_flag_extensions expects &[StreamableHttpOptions] (defined at line 33 of builder.rs), but this change passes &[String]. The StreamableHttpOptions struct contains both url and timeout information (used at line 59 in parse_cli_flag_extensions), so extracting just the URLs will break the functionality and cause a compilation error.

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Lymah123 · 2026-02-05T03:41:00Z

@Lymah123 looking better thanks! I think a few more things from copilot are left unresolved and seem worthy of fixing.

Duplicate header key validation - Add check in handleAddHeader to prevent adding headers with keys that already exist

Header edit validation - Add validation in handleHeaderChange or on form submit to catch invalid edits

Cannot clear headers - Change the logic so passing None or empty object clears headers, or update UI to send explicit empty object {} when user wants no headers

@zanesq, I have made the requested changes. Thanks!

Hello @zanesq !

zanesq · 2026-02-06T00:41:35Z

@Lymah123 apologies been real busy, can you pull in main and resolve the conflicts then I will do some more testing on this

…rForm Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Copilot · 2026-02-07T14:54:32Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+    const keyEmpty = !newHeaderKey.trim();
+    const valueEmpty = !newHeaderValue.trim();
+    const keyHasSpaces = newHeaderKey.includes(' ');
+    const isDuplicate = headers.some(h => h.key.trim() === newHeaderKey.trim());


Duplicate header detection is case-sensitive, but HTTP header names are case-insensitive; allowing both X-Foo and x-foo will lead to one overwriting the other when converted into a real header map. Normalize names (e.g., compare toLowerCase().trim()) for duplicate checks and ideally also when serializing to the request object.

Suggested change

const isDuplicate = headers.some(h => h.key.trim() === newHeaderKey.trim());

const normalizedNewKey = newHeaderKey.trim().toLowerCase();

const isDuplicate = headers.some(h => h.key.trim().toLowerCase() === normalizedNewKey);

Copilot · 2026-02-07T14:54:33Z

ui/desktop/src/components/settings/extensions/modal/HeadersSection.tsx

    const keyEmpty = !newKey.trim();
    const valueEmpty = !newValue.trim();
    const keyHasSpaces = newKey.includes(' ');
+    const isDuplicate = headers.some(h => h.key.trim() === newKey.trim());


Duplicate header detection is currently case-sensitive, but HTTP header names are case-insensitive; this can allow logically-duplicate headers that later overwrite each other at request time. Normalize header names (e.g., trim().toLowerCase()) in the duplicate check (and ideally during add) to match runtime behavior.

Suggested change

const isDuplicate = headers.some(h => h.key.trim() === newKey.trim());

const normalizedNewKey = newKey.trim().toLowerCase();

const isDuplicate = headers.some(

h => h.key.trim().toLowerCase() === normalizedNewKey

);

Copilot · 2026-02-07T14:54:33Z

ui/desktop/src/components/settings/extensions/modal/ExtensionModal.tsx

+      const isDuplicate = formData.headers.some((h, i) => i !== index && h.key.trim() === value.trim());
+      if (isDuplicate && value.trim() !== '') {


The duplicate-header guard compares keys case-sensitively, but HTTP header names are case-insensitive, so users can enter Authorization and authorization and have one overwrite the other when building the request headers. Normalize to a consistent case for duplicate detection (and consider normalizing on write).

Suggested change

const isDuplicate = formData.headers.some((h, i) => i !== index && h.key.trim() === value.trim());

if (isDuplicate && value.trim() !== '') {

const trimmedNewKey = value.trim();

const normalizedNewKey = trimmedNewKey.toLowerCase();

const isDuplicate = formData.headers.some(

(h, i) => i !== index && h.key.trim().toLowerCase() === normalizedNewKey,

);

if (isDuplicate && trimmedNewKey !== '') {

Copilot · 2026-02-07T14:54:33Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+      if (initialData.headers) {
+        const headerList = Object.entries(initialData.headers).map(([key, value]) => ({
+          key,
+          value,
+        }));


Custom headers won’t be preserved when editing an existing provider because initialData.headers is the only source for initializing headers, but the modal currently builds initialData without copying editingProvider.config.headers; this will cause updates to overwrite existing headers with an empty set. Pass headers: editingProvider.config.headers ?? undefined/null into initialData (and consider omitting headers on submit when unchanged) so edits don’t accidentally clear server-side config.

Copilot · 2026-02-07T14:54:34Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+    const headersObject = headers.reduce(
+      (acc, header) => {
+        if (header.key.trim() && header.value.trim()) {
+          acc[header.key.trim()] = header.value.trim();
+        }
+        return acc;
+      },
+      {} as Record<string, string>
+    );
+


newHeaderKey/newHeaderValue aren’t included in the submit payload, so if the user fills the fields and presses Enter or clicks “Create/Update” without clicking “Add”, the header is silently dropped. Consider handling Enter to call handleAddHeader, and/or blocking submit while there’s pending header input (similar to the extensions HeadersSection pattern) or auto-adding the pending header during submit.

Suggested change

const headersObject = headers.reduce(

(acc, header) => {

if (header.key.trim() && header.value.trim()) {

acc[header.key.trim()] = header.value.trim();

}

return acc;

},

{} as Record<string, string>

);

const headersObject: Record<string, string> = {};

// Include any pending header input so it isn't dropped on submit

if (newHeaderKey?.trim() && newHeaderValue?.trim()) {

headersObject[newHeaderKey.trim()] = newHeaderValue.trim();

}

headers.forEach((header) => {

const key = header.key.trim();

const value = header.value.trim();

if (key && value) {

headersObject[key] = value;

}

});

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-07T15:25:52Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

+      const isDuplicate = headers.some((h, i) => i !== index && h.key.trim() === value.trim());
+      if (isDuplicate && value.trim() !== '') {
+        return;
+      }


handleHeaderChange prevents duplicate header names using a case-sensitive comparison, but headers are case-insensitive and handleAddHeader normalizes to lowercase; this can allow duplicates like Authorization vs authorization which then get silently overwritten when building headersObject on submit—normalize the duplicate check (and stored keys) consistently (e.g., trim + lowercase).

Suggested change

const isDuplicate = headers.some((h, i) => i !== index && h.key.trim() === value.trim());

if (isDuplicate && value.trim() !== '') {

return;

}

const normalizedValue = value.trim().toLowerCase();

const isDuplicate = headers.some(

(h, i) => i !== index && h.key.trim().toLowerCase() === normalizedValue,

);

if (isDuplicate && normalizedValue !== '') {

return;

}

const updatedHeaders = [...headers];

updatedHeaders[index].key = normalizedValue;

setHeaders(updatedHeaders);

return;

Copilot · 2026-02-07T15:25:53Z

ui/desktop/src/components/settings/providers/modal/subcomponents/forms/CustomProviderForm.tsx

      models: modelList,
      supports_streaming: supportsStreaming,
      requires_auth: requiresApiKey,
+      headers: Object.keys(headersObject).length > 0 ? headersObject : {},


headers is always sent as {} when no headers are present, which deserializes as Some(empty) on the backend and can unintentionally clear existing headers on update (the server merges via params.headers.or(existing_config.headers)); send undefined/null (omit the field) when there are no headers to preserve existing behavior and match the CLI’s Option<HashMap> semantics.

Suggested change

headers: Object.keys(headersObject).length > 0 ? headersObject : {},

headers: Object.keys(headersObject).length > 0 ? headersObject : undefined,

Lymah123 · 2026-02-07T15:31:51Z

@zanesq fixed!

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

zanesq

@Lymah123 thanks! I tested locally and pushed some minor fixes and cleanup LGTM.

* main: fix text editor view broken (#7167) docs: White label guide (#6857) Add PATH detection back to developer extension (#7161) docs: pin version in ci/cd (#7168) Desktop: - No Custom Headers field for custom OpenAI-compatible providers (#6681) feat: edit model and extensions of a recipe from GUI (#6804) feat: MCP support for agentic CLI providers (#6972)

* origin/main: (33 commits) fix: replace panic with proper error handling in get_tokenizer (#7175) Lifei/smoke test for developer (#7174) fix text editor view broken (#7167) docs: White label guide (#6857) Add PATH detection back to developer extension (#7161) docs: pin version in ci/cd (#7168) Desktop: - No Custom Headers field for custom OpenAI-compatible providers (#6681) feat: edit model and extensions of a recipe from GUI (#6804) feat: MCP support for agentic CLI providers (#6972) docs: keyring fallback to secrets.yaml (#7165) feat: load provider/model specified inside the recipe config (#6884) fix ask-ai bot hitting tool call limits (#7162) fix flatpak icon (#7154) [docs] Skills Marketplace UI Improvements (#7158) More no-window flags (#7122) feat: Allow overriding default bat themes using environment variables (#7140) Make the system prompt smaller (#6991) Pre release script (#7145) Spelling (#7137) feat(mcp): upgrade rmcp to 0.15.0 and advertise MCP Apps UI extension capability (#6927) ...

Copilot AI review requested due to automatic review settings January 23, 2026 20:35

Copilot started reviewing on behalf of Lymah123 January 23, 2026 20:35 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Lymah123 force-pushed the desktop branch from 835d481 to 0cc1b17 Compare January 23, 2026 20:37

Copilot AI review requested due to automatic review settings January 23, 2026 21:01

Lymah123 force-pushed the desktop branch from 0cc1b17 to becab94 Compare January 23, 2026 21:01

Copilot started reviewing on behalf of Lymah123 January 23, 2026 21:02 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 24, 2026 14:48

Copilot started reviewing on behalf of Lymah123 January 24, 2026 14:49 View session

Copilot AI reviewed Jan 24, 2026

View reviewed changes

zanesq requested changes Jan 27, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 28, 2026 17:16

Copilot started reviewing on behalf of Lymah123 January 28, 2026 17:17 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Lymah123 requested a review from zanesq January 28, 2026 17:35

Lymah123 added 4 commits January 30, 2026 17:33

Add Custom Headers field for custom OpenAI-compatible providers

6a1d89f

- Added custom headers section to CustomProviderForm.tsx - Fixed modal scrolling issue in ProviderGrid.tsx - Fixed duplicate variable declaration in ChatInput.tsx Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Backend: Add headers parameter to update_custom_provider

5f8bfb3

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Fix CI errors: clippy too_many_arguments and merge conflicts

ee1f223

- Added #[allow(clippy::too_many_arguments)] to update_custom_provider - Resolved all merge conflict markers in ChatInput.tsx Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Fix CI failures from upstream merge

5e24e25

- Remove unused StreamableHttpOptions import - Extract URLs from StreamableHttpOptions for parse_cli_flag_extensions - Remove extra blank line for fmt check Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot AI review requested due to automatic review settings January 30, 2026 16:38

Lymah123 force-pushed the desktop branch from 2e0b83d to 5e24e25 Compare January 30, 2026 16:38

Copilot started reviewing on behalf of Lymah123 January 30, 2026 16:39 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Fix merge conflicts and compilation errors

6ffc508

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Lymah123 requested a review from Copilot January 30, 2026 17:08

Lymah123 requested a review from zanesq January 31, 2026 20:20

zanesq self-assigned this Feb 6, 2026

Lymah123 added 2 commits February 7, 2026 15:36

Merge upstream/main: resolve conflicts in ChatInput and CustomProvide…

17dbd41

…rForm Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Fix TypeScript error: remove undefined recordingDuration parameter

6a252f8

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot AI review requested due to automatic review settings February 7, 2026 14:50

Copilot started reviewing on behalf of Lymah123 February 7, 2026 14:50 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

Lymah123 added 3 commits February 7, 2026 16:01

handling pending header inputs in submit payload

cc9d272

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

handling pending header inputs in submit payload

6307992

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

handling pending header inputs in submit payload

c8eb7c2

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

Copilot AI review requested due to automatic review settings February 7, 2026 15:21

Copilot started reviewing on behalf of Lymah123 February 7, 2026 15:22 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

Lymah123 and others added 2 commits February 7, 2026 17:07

handling pending header inputs in submit payload

f502c7e

Signed-off-by: Lymah123 <fimihanodunola625@gmail.com>

cleanup and allow clearing all headers

601fcd6

Copilot AI review requested due to automatic review settings February 12, 2026 00:16

Copilot AI reviewed Feb 12, 2026

View reviewed changes

zanesq approved these changes Feb 12, 2026

View reviewed changes

zanesq enabled auto-merge February 12, 2026 00:18

zanesq added this pull request to the merge queue Feb 12, 2026

Merged via the queue into block:main with commit f96d38e Feb 12, 2026
19 checks passed

github-actions bot mentioned this pull request Feb 12, 2026

chore(release): release version 1.24.0 (minor) #7102

Closed

BrewTestBot mentioned this pull request Feb 12, 2026

block-goose-cli 1.24.0 Homebrew/homebrew-core#267289

Merged

github-actions bot mentioned this pull request Feb 17, 2026

chore(release): release version 1.25.0 (minor) #7263

Open

	className="flex items-center justify-start gap-1 px-2 pr-4 text-sm rounded-full text-textStandard bg-background-default border border-borderSubtle hover:border-borderStandard transition-colors min-w-[60px] h-9 [&>svg]:size-4!"
	className="flex items-center justify-start gap-1 px-2 pr-4 text-sm rounded-full text-textStandard bg-background-default border border-borderSubtle hover:border-borderStandard transition-colors min-w-[60px] h-9 [&>svg]:!size-4"

		.map_err(\|_\| StatusCode::INTERNAL_SERVER_ERROR)?;
		>>>>>>> 04269837bc8 (Backend: Add headers parameter to update_custom_provider)

	const isDuplicate = headers.some(h => h.key.trim() === newHeaderKey.trim());
	const normalizedNewKey = newHeaderKey.trim().toLowerCase();
	const isDuplicate = headers.some(h => h.key.trim().toLowerCase() === normalizedNewKey);

		const isDuplicate = formData.headers.some((h, i) => i !== index && h.key.trim() === value.trim());
		if (isDuplicate && value.trim() !== '') {

-      const isDuplicate = formData.headers.some((h, i) => i !== index && h.key.trim() === value.trim());
-      if (isDuplicate && value.trim() !== '') {
+      const trimmedNewKey = value.trim();
+      const normalizedNewKey = trimmedNewKey.toLowerCase();
+      const isDuplicate = formData.headers.some(
+        (h, i) => i !== index && h.key.trim().toLowerCase() === normalizedNewKey,
+      );
+      if (isDuplicate && trimmedNewKey !== '') {

-    const headersObject = headers.reduce(
-      (acc, header) => {
-        if (header.key.trim() && header.value.trim()) {
-          acc[header.key.trim()] = header.value.trim();
-        }
-        return acc;
-      },
-      {} as Record<string, string>
-    );
+    const headersObject: Record<string, string> = {};
+    // Include any pending header input so it isn't dropped on submit
+    if (newHeaderKey?.trim() && newHeaderValue?.trim()) {
+      headersObject[newHeaderKey.trim()] = newHeaderValue.trim();
+    }
+    headers.forEach((header) => {
+      const key = header.key.trim();
+      const value = header.value.trim();
+      if (key && value) {
+        headersObject[key] = value;
+      }
+    });

	headers: Object.keys(headersObject).length > 0 ? headersObject : {},
	headers: Object.keys(headersObject).length > 0 ? headersObject : undefined,

Conversation

Lymah123 commented Jan 23, 2026 • edited by zanesq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

AI Assistance

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

zanesq commented Jan 23, 2026

Uh oh!

Lymah123 commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

zanesq Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Lymah123 commented Jan 24, 2026

Uh oh!

zanesq Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Lymah123 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

zanesq Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

zanesq Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Lymah123 commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Lymah123 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Lymah123 commented Jan 23, 2026 •

edited by zanesq

Loading