fix(windows): prevent console window flickering when spawning subproc…#6827
Closed
Yorisoft wants to merge 1 commit intoblock:mainfrom
Closed
fix(windows): prevent console window flickering when spawning subproc…#6827Yorisoft wants to merge 1 commit intoblock:mainfrom
Yorisoft wants to merge 1 commit intoblock:mainfrom
Conversation
…esses On Windows, shell commands were causing PowerShell/Command Prompt windows to briefly flash on screen. This was a regression where the CREATE_NO_WINDOW flag (0x08000000) was not being applied when spawning subprocesses. Apply the flag to all subprocess creation points in goose-mcp Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
Contributor
|
If anyone can test on windows, please do! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From my understanding of discord discussion, what other devs have shared, and AI assisted debugging, my understanding is:
On Windows, shell commands were causing PowerShell/Command Prompt
windows to briefly flash on screen. This was a regression where the
CREATE_NO_WINDOW flag (0x08000000)was not being applied when spawningsubprocesses.
Apply the flag to all subprocess creation points in goose-mcp
Type of Change
AI Assistance
Testing
Unable to test: On linux.
Related Issues
Discussion: LINK
Screenshots/Demos (for UX changes)
Before:
After: