Remove clippy too_many_lines lint and decompose long functions

.github/copilot-instructions.md

@@ -56,7 +56,7 @@
 **Rust checks:**
 - `cargo fmt --check` - Code formatting (rustfmt)
 - `cargo test --jobs 2` - All tests
-- `./scripts/clippy-lint.sh` - Linting (clippy)
+- `cargo clippy --all-targets -- -D warnings` - Linting (clippy)
 - `just check-openapi-schema` - OpenAPI schema validation
 
 **Desktop app checks:**
@@ -76,7 +76,7 @@
 
 Do not comment on:
 - **Style/formatting** - CI handles this (rustfmt, prettier)
-- **Clippy warnings** - CI handles this (clippy-lint.sh)
+- **Clippy warnings** - CI handles this (clippy)
 - **Test failures** - CI handles this (full test suite)
 - **Missing dependencies** - CI handles this (npm ci will fail)
 - **Minor naming suggestions** - unless truly confusing

.github/workflows/ci.yml

@@ -95,7 +95,10 @@ jobs:
           # play nicely with hermit-managed rust
           hermit uninstall rustup
           export CARGO_INCREMENTAL=0
-          ./scripts/clippy-lint.sh
+          cargo clippy --all-targets -- -D warnings
+
+      - name: Check for banned TLS crates
+        run: ./scripts/check-no-native-tls.sh
 
   openapi-schema-check:
     name: Check OpenAPI Schema is Up-to-Date

.github/workflows/goose-issue-solver.yml

@@ -95,7 +95,7 @@ env:
       - [ ] cargo check
       - [ ] cargo test (affected crates)
       - [ ] cargo fmt
-      - [ ] ./scripts/clippy-lint.sh
+      - [ ] cargo clippy --all-targets -- -D warnings
       - [ ] Fix failures, retry up to 3 times
 
       ## Phase 6: Confirm (MANDATORY)

AGENTS.md

@@ -28,8 +28,7 @@ just record-mcp-tests        # record MCP
 ### Lint/Format
 ```bash
 cargo fmt
-./scripts/clippy-lint.sh
-cargo clippy --fix
+cargo clippy --all-targets -- -D warnings
 ```
 
 ### UI
@@ -63,7 +62,7 @@ ui/desktop/           # Electron app
 # 3. cargo fmt
 # 4. cargo build
 # 5. cargo test -p <crate>
-# 6. ./scripts/clippy-lint.sh
+# 6. cargo clippy --all-targets -- -D warnings
 # 7. [if server] just generate-openapi
 ```
 
@@ -92,7 +91,7 @@ Logging: Clean up existing logs, don't add more unless for errors or security ev
 Never: Edit ui/desktop/openapi.json manually
 Never: Edit Cargo.toml use cargo add
 Never: Skip cargo fmt
-Never: Merge without ./scripts/clippy-lint.sh
+Never: Merge without running clippy
 Never: Comment self-evident operations (`// Initialize`, `// Return result`), getters/setters, constructors, or standard Rust idioms
 
 ## Entry Points

CONTRIBUTING.md

@@ -103,7 +103,7 @@ When making changes to the Rust code, test them on the CLI or run checks, tests,
 cargo check  # verify changes compile
 cargo test  # run tests with changes
 cargo fmt   # format code
-./scripts/clippy-lint.sh # run the linter
+cargo clippy --all-targets -- -D warnings # run the linter
 ```
 
 ### Node

HOWTOAI.md

@@ -142,7 +142,7 @@ If you're new to Rust, configure your AI tool to help you learn:
 This is a Rust project using cargo workspaces.
 - Follow existing error handling patterns using anyhow::Result
 - Use async/await for I/O operations
-- Follow the project's clippy lints (see clippy-baselines/)
+- Follow the project's clippy lints (see clippy.toml)
 - Run cargo fmt before committing
 ```
 
@@ -240,7 +240,7 @@ cargo build -p goose-mcp
 cargo test -p goose-mcp
 
 # Run clippy
-./scripts/clippy-lint.sh
+cargo clippy --all-targets -- -D warnings
 ```
 
 ### Example 2: Fixing a Rust Compiler Error
@@ -314,4 +314,4 @@ cargo build -p goose-cli -p goose
 
 # Run tests
 cargo test -p goose-cli
-```
+```

Justfile

@@ -10,7 +10,9 @@ check-everything:
     @echo "  → Formatting Rust code..."
     cargo fmt --all
     @echo "  → Running clippy linting..."
-    ./scripts/clippy-lint.sh
+    cargo clippy --all-targets -- -D warnings
+    @echo "  → Checking for banned TLS crates..."
+    ./scripts/check-no-native-tls.sh
     @echo "  → Checking UI code formatting..."
     cd ui/desktop && npm run lint:check
     @echo "  → Validating OpenAPI schema..."

clippy.toml

@@ -0,0 +1 @@
+too-many-lines-threshold = 200