Skip to content

fix: use dynamic port for Tetrate auth callback server#7228

Merged
michaelneale merged 1 commit intoblock:mainfrom
raj-subhankar:dynamic-port
Feb 15, 2026
Merged

fix: use dynamic port for Tetrate auth callback server#7228
michaelneale merged 1 commit intoblock:mainfrom
raj-subhankar:dynamic-port

Conversation

@raj-subhankar
Copy link
Collaborator

@raj-subhankar raj-subhankar commented Feb 15, 2026

Summary

  • The Tetrate login auth callback server was hardcoded to port 3000, causing failures when that port was already in use
  • Changed to bind to port 0 (OS assigned), read back the actual port, and pass it into the auth URL dynamically
  • The listener is now created by the caller and passed into run_callback_server, keeping port knowledge in one place

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

Fixed port 3000

Goose.Tetrate.login.before.mov

After:

Dynamic port allocation

Dynamic.port.720.mov

@raj-subhankar
Use dynamic port
95325f4 
Signed-off-by: raj-subhankar <subhankar.rj@gmail.com>
Copilot AI review requested due to automatic review settings February 15, 2026 06:09
Copilot AI reviewed Feb 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a port conflict issue in the Tetrate authentication flow by changing from a hardcoded port 3000 to dynamic OS-assigned port allocation. The solution creates the TCP listener early (binding to port 0), reads back the actual assigned port, and passes it into the auth URL. This refactoring also simplifies the code by removing the start_server() method and consolidating all server setup logic into complete_flow().

Changes:

  • Modified auth callback server to use dynamic port allocation instead of hardcoded port 3000
  • Refactored server initialization to accept a pre-created listener, keeping port knowledge centralized
  • Updated tests and examples to reflect the dynamic port behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/goose/src/config/signup_tetrate/server.rs Removed hardcoded port binding; run_callback_server now accepts a pre-created listener
crates/goose/src/config/signup_tetrate/mod.rs Consolidated server setup into complete_flow(); removed start_server() method; changed get_auth_url() to accept dynamic port
crates/goose/src/config/signup_tetrate/tests.rs Updated test to verify dynamic port is correctly included in auth URL
crates/goose/examples/tetrate_auth.rs Updated example documentation to reflect dynamic port allocation

michaelneale
michaelneale approved these changes Feb 15, 2026
View reviewed changes
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, not the easiest to hand test but lets get it in the next

@michaelneale michaelneale added this pull request to the merge queue Feb 15, 2026
Merged via the queue into block:main with commit 4a5210e Feb 15, 2026
24 of 25 checks passed
michaelneale added a commit that referenced this pull request Feb 16, 2026
@michaelneale
Merge remote-tracking branch 'origin/main' into gateway-abstraction
661def6 
* origin/main: (42 commits)
  fix: use dynamic port for Tetrate auth callback server (#7228)
  docs: removing LLM Usage admonitions (#7227)
  feat(otel): respect standard OTel env vars for exporter selection (#7144)
  fix: fork session (#7219)
  Bump version numbers for 1.24.0 release (#7214)
  Move platform extensions into their own folder (#7210)
  fix: ignore deprecated skills extension (#7139)
  Add a goosed over HTTP integration test, and test the developer tool PATH (#7178)
  feat: add onFallbackRequest handler to McpAppRenderer (#7208)
  feat: add streaming support for Claude Code CLI provider (#6833)
  fix: The detected filetype is PLAIN_TEXT, but the provided filetype was HTML (#6885)
  Add prompts (#7212)
  Add testing instructions for speech to text (#7185)
  Diagnostic files copying (#7209)
  fix: allow concurrent tool execution within the same MCP extension (#7202)
  fix: handle missing arguments in MCP tool calls to prevent GUI crash (#7143)
  Filter Apps page to only show standalone Goose Apps (#6811)
  opt: use static for Regex (#7205)
  nit: show dir in title, and less... jank (#7138)
  feat(gemini-cli): use stream-json output and re-use session (#7118)
  ...
@github-actions github-actions bot mentioned this pull request Feb 17, 2026
Open
tlongwell-block added a commit that referenced this pull request Feb 17, 2026
@tlongwell-block
Merge remote-tracking branch 'origin/main' into tui_gem
1e293fc 
* origin/main:
  docs: playwright CLI skill tutorial (#7261)
  install node in goose dir (#7220)
  fix: relax test_basic_response assertion for providers returning reasoning_content (#7249)
  fix: handle reasoning_content for Kimi/thinking models (#7252)
  feat: sandboxing for macos (#7197)
  fix(otel): use monotonic_counter prefix and support temporality env var (#7234)
  Streaming markdown (#7233)
  Improve compaction messages to enable better post-compaction agent behavior (#7259)
  fix: avoid shell-escaping special characters except quotes (#7242)
  fix: use dynamic port for Tetrate auth callback server (#7228)
  docs: removing LLM Usage admonitions (#7227)
  feat(otel): respect standard OTel env vars for exporter selection (#7144)
  fix: fork session (#7219)
  Bump version numbers for 1.24.0 release (#7214)
  Move platform extensions into their own folder (#7210)
  fix: ignore deprecated skills extension (#7139)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
zanesq added a commit that referenced this pull request Feb 17, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/validate-bund…
9ccc8eb 
…led-extensions-cmd

* 'main' of github.com:block/goose: (24 commits)
  Set up direnv and update flake inputs (#6526)
  fix: restore subagent tool call notifications after summon refactor (#7243)
  fix(ui): preserve server config values on partial provider config save (#7248)
  fix(claude-code): allow goose to run inside a Claude Code session (#7232)
  fix(openai): route gpt-5 codex via responses and map base paths (#7254)
  feat: add GoosePlatform to AgentConfig and MCP initialization (#6931)
  Fix copied over (#7270)
  feat(gemini-cli): add streaming support via stream-json events (#7244)
  fix: filter models without tool support from recommended list (#7198)
  fix(google): handle more thoughtSignature vagaries during streaming (#7204)
  docs: playwright CLI skill tutorial (#7261)
  install node in goose dir (#7220)
  fix: relax test_basic_response assertion for providers returning reasoning_content (#7249)
  fix: handle reasoning_content for Kimi/thinking models (#7252)
  feat: sandboxing for macos (#7197)
  fix(otel): use monotonic_counter prefix and support temporality env var (#7234)
  Streaming markdown (#7233)
  Improve compaction messages to enable better post-compaction agent behavior (#7259)
  fix: avoid shell-escaping special characters except quotes (#7242)
  fix: use dynamic port for Tetrate auth callback server (#7228)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@michaelneale michaelneale michaelneale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raj-subhankar @michaelneale

Comments