refactor: remove allows_unlisted_models flag, always allow custom model entry#7255
Open
clayarnoldg2m wants to merge 1 commit intoblock:mainfrom
Open
Conversation
…el entry Remove the allows_unlisted_models field from ProviderMetadata and its with_unlisted_models() builder. All providers now always allow users to enter custom model names not in the fetched list. Changes: - Remove field, builder, and defaults from base.rs - Remove .with_unlisted_models() from 7 providers - Simplify configure.rs to always show "Enter a model not listed..." - Clean up provider_registry.rs and test mocks - Update RecipeModelSelector.tsx and SwitchModelModal.tsx - Regenerate OpenAPI schema and TypeScript types Fixes block#7103 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: clayarnoldg2m <carnold@g2m.ai>
Collaborator
|
I am ok with this - I can see that we have been adding the flag one by one, but why even have it? this reduces complexity, I like it, but @codefromthecrypt - you ok with it? stamp if you think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allows_unlisted_modelsfield fromProviderMetadataand itswith_unlisted_models()builder methodconfigure.rsto unconditionally show "Enter a model not listed..." optionRecipeModelSelector.tsxandSwitchModelModal.tsxto always show custom model entryTest plan
cargo clippy --all-targets -- -D warnings— cleancargo test— passes (2 pre-existing integration failures: claude_code, xai)npx tsc --noEmit— cleanjust generate-openapi— regenerated, noallows_unlisted_modelsreferences remainFixes #7103
🤖 Generated with Claude Code