Open
Conversation
Abhijay007
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the confirm-open-link modal not scrolling when URLs are very long,
making the action buttons unreachable.
Replaced the native Electron
showMessageBoxdialog with the existing ReactConfirmationModalcomponent for the external link confirmation flow. TheConfirmationModalnow supports an optional scrollable detail section withmax viewport height constraints, so long URLs wrap and scroll while the
Cancel/Open buttons always remain visible and accessible.
Also added error handling for when no application is found to open the
link protocol, and improved keyboard focus visibility on the modal buttons
using the theme accent color instead of the barely-visible default ring.