fix(desktop): expand ACP discovery to include version-manager shim dirs#375
Merged
Conversation
Users with Claude ACP installed via mise, volta, asdf, or pip had the binary in non-standard paths (e.g. ~/.local/share/mise/shims/) that the app couldn't find when launched from the release DMG. Replaces the static COMMON_BINARY_PATHS const with an OnceLock-cached function that includes version-manager shim directories resolved via $HOME at runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMON_BINARY_PATHSconst with anOnceLock-cachedcommon_binary_paths()function that includes version-manager shim directories (~/.local/share/mise/shims,~/.local/bin,~/.volta/bin,~/.asdf/shims)$HOMEat runtime viadirs::home_dir()(already a dependency)Context
Users running the release DMG couldn't discover Claude ACP when installed via version managers (e.g.
~/.local/share/mise/installs/node/23.11.0/bin/claude-agent-acp). PR #372 fixed the spawn-side PATH but not discovery. This adds the common shim directories as a last-resort fallback in the existing resolution chain.Test plan
cargo checkcompiles cleanlycargo clippyclean🤖 Generated with Claude Code