Move relay admin panel to NIP-43 message path#494
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15712fd71b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export async function listRelayMembers(): Promise<RelayMember[]> { | ||
| const event = await fetchMembershipListEvent(); | ||
| return event ? relayMembersFromEvent(event) : []; |
There was a problem hiding this comment.
Distinguish missing NIP-43 snapshot from denied membership
Returning an empty list when no kind 13534 event exists makes getMyRelayMembership() resolve to null, which onboarding interprets as “access denied” (checkMembershipDenied in OnboardingFlow.tsx). On relays with membership gating disabled, the server does not publish the startup 13534 snapshot, so this path incorrectly sends normal users to the membership-denied flow before profile save. Please treat “no snapshot available” as a non-denial state (or explicitly surface an unknown state) instead of collapsing it to “not a member.”
Useful? React with 👍 / 👎.
Summary
Test plan