chore: remove dead API token references from GUI, docs, and config#498
Merged
Conversation
PR #475 deleted the REST API and Bearer token auth, replacing it with pure Nostr (Schnorr signatures via NIP-42/NIP-98). This commit removes the leftover client-side references, documentation, and config that pointed at the now-dead token system. Desktop: delete features/tokens/ directory, token settings tab, token types/hooks/mutations, agent creation token UI, token E2E tests and mocks. Mobile: clean test fixtures. Docs: update 7 files to reflect NIP-42/NIP-98 auth model. Config: remove SPROUT_API_TOKEN env vars, clean justfile token parameters. CI: add dead-token-guard job to prevent reintroduction. Relay-side auth code (api_tokens table, require_auth_token config, X-Auth-Token media path) intentionally left for a follow-up PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Okta OIDC integration (PR #293) was never merged. Remove all residual documentation, config, and dependencies: - Remove OKTA_* env vars from .env.example and README - Remove Nip42Okta, JWKS caching, and Okta JWT auth from ARCHITECTURE.md - Remove unused jsonwebtoken crate from workspace Cargo.toml - Delete dead scripts/setup-keycloak.sh - Clean stale JWT/OIDC terminology from NOSTR.md, VISION.md, CONTRIBUTING.md, and config.rs comments Schema (okta_user_id column) and docker-compose Keycloak service deferred to relay auth follow-up PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wesbillman
force-pushed
the
api-token-cleanup
branch
from
a7be394 to
5ee0555
Compare
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #475 deleted the REST API and Bearer token auth, replacing it with pure Nostr (Schnorr signatures via NIP-42/NIP-98). PR #478 migrated desktop, mobile, and ACP clients. This PR removes the leftover client-side references, documentation, and config that pointed at the now-dead token system.
features/tokens/directory, token settings tab, token types/hooks/mutations, agent creation token UI, token E2E tests and mocksmedia_upload.dartdeferred to follow-up)SPROUT_API_TOKENenv vars, clean justfile token parameters, deduplicateSPROUT_REQUIRE_AUTH_TOKENdead-token-guardjob to prevent reintroduction of token patterns in client codeWhat's NOT in this PR (follow-up)
Relay-side auth code is intentionally left for a separate PR:
crates/sprout-relay/(require_auth_token config, X-Auth-Token media path)crates/sprout-db/(api_tokens table, ApiTokenRecord, CRUD functions)schema/schema.sql(api_tokens table)crates/sprout-acp/(legacy env var propagation)mobile/lib/shared/relay/media_upload.dart(production X-Auth-Token field)Numbers
Test plan
pnpm typecheck— cleanpnpm build— cleanflutter analyze— cleanflutter test— all passing (including modified media_upload_test.dart)cargo test(unit) — 183/183 passing🤖 Generated with Claude Code