feat(desktop): reusable AvatarUpload for onboarding and settings#502
Merged
Conversation
… and settings Extract avatar upload logic from onboarding into a shared useAvatarUpload hook and AvatarUpload component. Wire the new component into both the onboarding ProfileStep and the Settings ProfileSettingsCard, replacing the URL-only input in Settings with full file upload support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ettings avatar UX - Expose isUploading from AvatarUpload via onUploadingChange callback so onboarding canSubmit gates on upload-in-progress (prevents submitting before upload completes) - Add idleHint prop to AvatarUpload for context-appropriate helper text - Restore ProfileAvatar in Settings header for visual consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAvatarUploadhook andAvatarUploadcomponent infeatures/profile/ProfileStepand the SettingsProfileSettingsCardOnboardingFlow.tsxandtypes.tsFiles changed
desktop/src/features/profile/useAvatarUpload.ts— Hook: MIME validation,uploadMediaBytescall, loading/error statedesktop/src/features/profile/ui/AvatarUpload.tsx— Reusable component: avatar preview + upload button + URL input + error bannerdesktop/src/features/onboarding/ui/ProfileStep.tsx— Replaced inlineAvatarSectionwithAvatarUploaddesktop/src/features/onboarding/ui/OnboardingFlow.tsx— Removed avatar upload state/callbacksdesktop/src/features/onboarding/ui/types.ts— SimplifiedProfileStepAvatarStateandProfileStepActionsdesktop/src/features/settings/ui/ProfileSettingsCard.tsx— Replaced URL-only input withAvatarUploadTest plan
onboarding-avatar-upload,onboarding-avatar-url,profile-avatar-url)pnpm checkandtsc --noEmitpass🤖 Generated with Claude Code