fix(desktop): prevent Radix Checkbox from swallowing persona row clicks#505
Merged
Conversation
Radix UI's Checkbox internally calls stopPropagation on click events,
which prevents the parent row's onClick from firing. This made clicking
near the checkbox area unreliable — either nothing happened or a
double-toggle cancelled out.
Make the Checkbox purely presentational by removing onCheckedChange,
adding pointer-events-none so clicks pass through to the row handler,
and tabIndex={-1} to avoid double-focus since the row is already
focusable.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
wesbillman
approved these changes
May 8, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
team.toggle.broken.mov
After
team.toggle.fixed.mov
Summary
Checkboxinside persona rows from intercepting click events that should toggle the rowpointer-events-noneandtabIndex={-1}to make the checkbox purely visual, letting the parent row handler manage toggle behavioronCheckedChangehandler since the row'sonClickalready callstogglePersona🤖 Generated with Claude Code