Onboarding cleanup: notifications + profile polish#508
Merged
Conversation
… on first send Strip the desktop notifications card from the onboarding SetupStep — notifications now default to enabled for new users and the OS permission prompt fires organically on first notification delivery via the feed notification hook. - Flip desktopEnabled default to true in DEFAULT_NOTIFICATION_SETTINGS - Add auto-permission-request in useFeedDesktopNotifications (with denial → setDesktopEnabled(false)) - Add module-level promise dedup on requestDesktopNotificationAccess to prevent concurrent OS prompts - Extract useFeedDesktopNotifications to its own file to stay under file size limit - Remove notification card, types, props, and callbacks from onboarding flow - Update E2E tests to expect new default state - Update Settings copy to reflect new default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move "Add a profile photo" header above avatar row as section label - Replace upload button with dashed-border drag-and-drop zone - Add X badge on avatar to clear draft (replaces Undo button) - Move npub display + copy button into bottom action row - Remove wordy copy and helper text for cleaner onboarding feel Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm typecheckandpnpm checkin desktop — both pass🤖 Generated with Claude Code