Skip to content

Onboarding cleanup: notifications + profile polish#508

Merged
wesbillman merged 3 commits into
mainfrom
onboard-cleanup-notifications
May 8, 2026
Merged

Onboarding cleanup: notifications + profile polish#508
wesbillman merged 3 commits into
mainfrom
onboard-cleanup-notifications

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

Summary

  • Remove notification step from onboarding — auto-request notification permission on first message send instead of a dedicated setup step, reducing onboarding friction
  • Polish profile step UI — replace upload button with drag-and-drop zone, move "Add a profile photo" to section header, add X badge to clear avatar draft, move npub + copy button into bottom action row, trim verbose copy

Test plan

  • Verify onboarding flow skips the notification step and goes straight to profile → done
  • Confirm notification permission is requested on first message send
  • Test avatar upload via drag-and-drop zone (drop file + click to browse)
  • Test avatar clear X badge appears when draft differs from saved
  • Verify npub + copy button in bottom row works
  • Check profile settings page still renders AvatarUpload correctly (shared component)
  • Run pnpm typecheck and pnpm check in desktop — both pass

🤖 Generated with Claude Code

wesbillman and others added 2 commits May 7, 2026 23:14
… on first send

Strip the desktop notifications card from the onboarding SetupStep — notifications
now default to enabled for new users and the OS permission prompt fires organically
on first notification delivery via the feed notification hook.

- Flip desktopEnabled default to true in DEFAULT_NOTIFICATION_SETTINGS
- Add auto-permission-request in useFeedDesktopNotifications (with denial → setDesktopEnabled(false))
- Add module-level promise dedup on requestDesktopNotificationAccess to prevent concurrent OS prompts
- Extract useFeedDesktopNotifications to its own file to stay under file size limit
- Remove notification card, types, props, and callbacks from onboarding flow
- Update E2E tests to expect new default state
- Update Settings copy to reflect new default

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move "Add a profile photo" header above avatar row as section label
- Replace upload button with dashed-border drag-and-drop zone
- Add X badge on avatar to clear draft (replaces Undo button)
- Move npub display + copy button into bottom action row
- Remove wordy copy and helper text for cleaner onboarding feel

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wesbillman wesbillman enabled auto-merge (squash) May 8, 2026 15:53
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wesbillman wesbillman merged commit d7714d5 into main May 8, 2026
15 checks passed
@wesbillman wesbillman deleted the onboard-cleanup-notifications branch May 8, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant