Skip to content

Use platform-native app shortcuts on macOS#521

Merged
wesbillman merged 1 commit into
mainfrom
mac-primary-shortcuts-emacs-text
May 10, 2026
Merged

Use platform-native app shortcuts on macOS#521
wesbillman merged 1 commit into
mainfrom
mac-primary-shortcuts-emacs-text

Conversation

@baxen
Copy link
Copy Markdown
Collaborator

@baxen baxen commented May 9, 2026

Summary

  • Require Command (not Control) for app-level shortcuts on macOS while keeping Control on Windows/Linux
  • Add shared platform shortcut helper and reuse it across search, settings, sidebar, find, and zoom shortcuts
  • Add macOS-only Emacs-style composer shortcuts for Ctrl-B, Ctrl-F, and Ctrl-K

Test Plan

  • cd desktop && pnpm exec tsc --noEmit
  • cd desktop && pnpm exec biome check src/app/AppShell.tsx src/app/navigation/useBackForwardControls.ts src/app/useWebviewZoomShortcuts.ts src/features/messages/lib/useRichTextEditor.ts src/features/search/useChannelFind.ts src/shared/lib/keyboard-shortcuts.ts src/shared/lib/platform.ts src/shared/ui/sidebar.tsx

@baxen baxen requested a review from wesbillman as a code owner May 9, 2026 20:27
Copy link
Copy Markdown
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wesbillman wesbillman merged commit e902037 into main May 10, 2026
15 checks passed
@wesbillman wesbillman deleted the mac-primary-shortcuts-emacs-text branch May 10, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants