fix(desktop): use resolve_command for ffmpeg discovery in sandboxed app#568
Merged
Conversation
Users with brew-installed ffmpeg get "not found" errors because the
sandboxed .app bundle doesn't inherit shell PATH. Replace naive
Command::new("ffmpeg") with resolve_command() from the discovery module,
which searches login shell PATH, /opt/homebrew/bin, /usr/local/bin, and
other common locations — the same chain used for managed agent binaries.
find_ffmpeg() now returns a PathBuf that threads through
transcode_to_mp4() and extract_poster_frame(), resolving once per upload.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The resolve_command migration added 9 net lines for proper ffmpeg discovery in sandboxed app context. Bump the guard rail to accommodate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appbundle doesn't inherit their shell PATHCommand::new("ffmpeg")PATH lookup inmedia.rswithresolve_command("ffmpeg", None)from the existing discovery moduleresolve_commandsearches login shell PATH,/opt/homebrew/bin,/usr/local/bin, and other common locations — the same chain used for managed agent binariesfind_ffmpeg()now returns aPathBufthat threads throughtranscode_to_mp4()andextract_poster_frame(), resolving once per uploadTest plan
.app(DMG install) with brew ffmpeg — this is the primary fix scenarioReview notes
resolve_commandchecks workspacetarget/dirs before PATH (irrelevant in.appcontext) and uses.exists()without executable check (the-versionsafety net catches non-executable files)🤖 Generated with Claude Code