fix(desktop): find bundled sidecars in production DMG builds#731
Merged
Conversation
command_search_dirs gated the exe parent directory behind an AppHandle check, but discover_acp_providers called find_command with app: None. In production DMGs, bundled sidecars live in Sprout.app/Contents/MacOS/ next to the main exe, so they were never found. Remove the guard so the exe parent is always searched.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
command_search_dirsgated the exe parent directory check behindif app.is_some(), butdiscover_acp_providers→find_commandpassesapp: None. In production DMGs, bundled sidecars (sprout-agent,sprout-mcp-server, etc.) live inSprout.app/Contents/MacOS/next to the main exe — but that directory was never searched.This caused the Doctor panel to show "Sprout Agent — Not installed" in released builds even though the binary was correctly bundled in the DMG.
AppHandleguard socurrent_exe().parent()is always included in the binary search pathtarget/paths already work — this only affects production app bundles