Skip to content

fix: UI fixes for system message avatars and agents page#749

Merged
wesbillman merged 5 commits into
mainfrom
rick/ui-fixes
May 26, 2026
Merged

fix: UI fixes for system message avatars and agents page#749
wesbillman merged 5 commits into
mainfrom
rick/ui-fixes

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

Summary

  • Make channel event avatars (e.g. "X created this channel") clickable by wrapping them in UserProfilePopover, matching normal chat message avatar behavior
  • Flatten nested cards on Agents page — agent rows now use divide-y separators instead of individual card borders within the group card
  • Clean up inline log panel — remove border/shadow/padding when rendered inside an agent row expansion area
  • Fix channelsByPubkey lookup to normalize pubkeys so channel badges display correctly on agent rows

Test plan

  • Click on an avatar in a system message (e.g. "X created this channel") → profile popover should appear
  • Click on dual avatars in system messages (e.g. "X added Y") → profile popover for the actor should appear
  • Check Agents page — agent rows within a persona group should not have individual card borders (no card-in-card)
  • Expand an agent's log — log panel should flow naturally without a nested card appearance
  • Verify channel badges appear on agent rows when agents are added to channels

🤖 Generated with Claude Code

- Make channel event avatars clickable by wrapping them in
  UserProfilePopover, matching normal chat message avatar behavior
- Flatten nested cards on Agents page by removing card styling from
  ManagedAgentRow and using divide-y separators instead
- Clean up inline log panel by removing card-like border/shadow/padding
  when rendered inside an agent row
- Fix channelsByPubkey lookup to normalize pubkeys so channel badges
  display correctly on agent rows

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wesbillman wesbillman requested a review from a team as a code owner May 26, 2026 15:27
wesbillman and others added 4 commits May 26, 2026 08:41
Not imported anywhere — superseded by UnifiedAgentsSection which uses
AgentGroupRows directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…l data

Move hover:bg-muted/40 from the inner button to the parent div so the
highlight spans the full row width including the actions menu area.

Supplement channelsByPubkey with channel.participantPubkeys so agent
rows show channel badges even when relay agent events lack embedded
channel membership data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous approach used Channel.participantPubkeys which is only
populated for DM channels (from p-tags on kind:39000 metadata events).
Regular channels don't carry member lists in their metadata.

Fix by adding member_pubkeys to ChannelInfo, populated from the
kind:39002 member events that get_channels already batch-fetches for
counting. The Rust side now returns both the count and the pubkey list
(collect_members_by_channel replaces count_members_by_channel). The
TypeScript side maps memberPubkeys through to the channelsByPubkey memo
so agent rows display channel badges.

Also adds overflow-hidden to persona group cards so the hover highlight
clips to the rounded border radius.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Switch from secondary (filled) to outline (bordered) variant to match
the Local/Remote origin badge style. Add tracking-normal to remove the
wide letter-spacing that the Badge base styles apply for uppercase
labels — channel names are normal-case so tight tracking reads better.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wesbillman
Copy link
Copy Markdown
Collaborator Author

Screenshot 2026-05-26 at 9 28 46 AM

Clean up agent rows a bit and show which channels the agent is in.

@wesbillman wesbillman merged commit 8a468a9 into main May 26, 2026
15 checks passed
@wesbillman wesbillman deleted the rick/ui-fixes branch May 26, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant