fix: agent management UI fixes (permissions, parallelism, form validation)#750
Merged
Conversation
…le comment - Remove `mcpCommandValid = true` (always-true, dead code since the backend now handles empty → default for mcp_command) - Remove mcpCommandValid from canSubmit conjunction - Update the acpCommandValid comment to accurately describe the remaining validation (was referencing a stale 'no clear-to-None path' rationale that no longer applies)
Previously only owner/admin could add members to private channels (with a bot-only exception). Now any member can invite anyone, matching Slack's behavior. Only elevated role grants (owner/admin) still require elevated permissions.
Three new integration tests in e2e_relay.rs: - test_private_channel_any_member_can_invite: verifies any member can invite others to a private channel (Slack model) - test_private_channel_non_member_cannot_invite: verifies outsiders are rejected - test_private_channel_member_cannot_grant_admin: verifies regular members cannot grant elevated (admin/owner) roles Also fixes a bug found during testing: the elevated-role check was only in the DB layer (which runs as a side effect after event storage), not in validate_admin_event (the pre-validation gate). Moved the check to validate_admin_event so events are properly rejected before storage.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five agent management fixes:
DEFAULT_MCP_COMMANDwhen empty string is submitted; UI validation removedautoComplete="off"to all Input fields in CreateAgentDialogSectionsFiles Changed
Relay/DB (permissions):
crates/sprout-db/src/channel.rs— allow non-elevated inviters when target role is Botcrates/sprout-relay/src/handlers/side_effects.rs— any channel member can add bots to private channelsDesktop (Rust):
desktop/src-tauri/src/commands/agent_models.rs— empty MCP command falls back to defaultdesktop/src-tauri/src/managed_agents/types.rs—DEFAULT_AGENT_PARALLELISM3 → 24Desktop (UI):
desktop/src/features/channels/ui/ChannelMembersBar.tsx— show add-agent for open channels or membersdesktop/src/features/channels/ui/MembersSidebar.tsx— owners can remove non-owner membersdesktop/src/features/agents/ui/CreateAgentDialog.tsx— parallelism default "24"desktop/src/features/agents/ui/EditAgentDialog.tsx— removed dead mcpCommandValid codedesktop/src/features/agents/ui/CreateAgentDialogSections.tsx— autoComplete="off"Notes
unused variable: appwarning indiscovery.rs:221is pre-existing on main, not from this PR