-
Notifications
You must be signed in to change notification settings - Fork 663
specify ad provider #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify ad provider #3005
Conversation
12b1e55 to
acc29e4
Compare
67691cc to
e064777
Compare
tom2drum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What causes the changes of the banner margins on the screenshots? Is it correct that the banner is not aligned properly to the left or to the right side? Or is it an issue with the tests?
Since we're adding fallback logics here, we decided to unite ad formats for all providers to avoid layout shifts. Slise provides mobile format as 270x90 instead of 320x100 from all the other providers. We scale 270x90 to 300x100, but reserved slot for ad is 320x100. It adds the horizontal 'margins' that is approved by product. |
Description and Related Issue(s)
resolves https://github.com/blockscout/epics/issues/20
Proposed Changes
added NEXT_PUBLIC_AD_BANNER_ENABLE_SPECIFY variable to enable Specify ad provider for connected users
Checklist for PR author