Skip to content

Add private named instance field transformation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mheiber merged 1 commit into from
Mar 27, 2019
Merged

Add private named instance field transformation #31

mheiber merged 1 commit into from
Mar 27, 2019

Conversation

@joeywatts
Copy link

@joeywatts joeywatts commented Mar 8, 2019

Implements private instance fields on top of the class properties refactor.

Add private named instance field transformation
a64e691 
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
mheiber
mheiber approved these changes Mar 14, 2019
View reviewed changes
Copy link

@mheiber mheiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
For posterity: these changes are the same as those in #15, but reapplied now that we've moved class fields logic from esnext.ts to classProperties.ts

This was referenced Mar 23, 2019
Closed
Closed
@mheiber mheiber merged commit 0162db0 into bloomberg:es-private-fields Mar 27, 2019
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Mar 27, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
6f3e5a4 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Mar 27, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
a97aa6b 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Mar 27, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
ecd1529 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Mar 28, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
3f6b68f 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Apr 9, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
b242db5 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Apr 9, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
f2c5233 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
joeywatts added a commit to joeywatts/TypeScript that referenced this pull request Jun 24, 2019
@joeywatts
Add private named instance field transformation (bloomberg#31)
a9cb10e 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
joeywatts added a commit to joeywatts/TypeScript that referenced this pull request Jun 26, 2019
@joeywatts
Add private named instance field transformation (bloomberg#31)
52393ea 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
joeywatts added a commit to joeywatts/TypeScript that referenced this pull request Jun 26, 2019
@joeywatts
Add private named instance field transformation (bloomberg#31)
5f22f66 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit that referenced this pull request Jun 27, 2019
@joeywatts
Add private named instance field transformation (#31)
f6151e9 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit to mheiber/TypeScript that referenced this pull request Sep 4, 2019
@joeywatts @mheiber
Add private named instance field transformation (bloomberg#31)
3f1527b 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
joeywatts added a commit to joeywatts/TypeScript that referenced this pull request Sep 10, 2019
@joeywatts
Add private named instance field transformation (bloomberg#31)
4427a64 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit that referenced this pull request Sep 11, 2019
@joeywatts @mheiber
Add private named instance field transformation (#31)
1364162 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber pushed a commit that referenced this pull request Sep 24, 2019
@joeywatts @mheiber
Add private named instance field transformation (#31)
5d15724 
Implements private instance fields on top of the class properties refactor.
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Max Heiber <max.heiber@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neuroboy23 Neuroboy23 Neuroboy23 approved these changes

@robpalme robpalme Awaiting requested review from robpalme

@ramin25 ramin25 Awaiting requested review from ramin25

+1 more reviewer

@mheiber mheiber mheiber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeywatts @mheiber @Neuroboy23