Add error logging around FileSink and header serialization failures#911
Merged
Conversation
godlygeek
requested changes
Apr 28, 2026
swaroski
force-pushed
the
add-error-logging-747
branch
from
8a91a14 to
3b1d7f7
Compare
Contributor
Author
|
@godlygeek addressed: dropped programming-error LOGs |
godlygeek
force-pushed
the
add-error-logging-747
branch
from
3b1d7f7 to
ce779f6
Compare
godlygeek
reviewed
Apr 28, 2026
godlygeek
reviewed
Apr 28, 2026
Capture file creation could fail with a generic RuntimeError of "Failed to write output header" when the destination filesystem did not support shared writable mmap or posix_fallocate, with no log indication of the underlying cause. Log the failing syscall, the errno, and (when failing on the first call) a hint to retry with a different output location such as /tmp. Refs bloomberg#747, bloomberg#731 Signed-off-by: Suyog Bhise <bhise.suyog@gmail.com>
godlygeek
force-pushed
the
add-error-logging-747
branch
from
fe23775 to
9510e67
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 92.46% 92.34% -0.13%
==========================================
Files 99 99
Lines 11748 11758 +10
Branches 427 427
==========================================
- Hits 10863 10858 -5
- Misses 885 900 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #747, #731
Summary
FileSink::seekandFileSink::grownow log the failing syscall (mmap,munmap,lseek,posix_fallocate),the errno string, and a hint to try writing the capture file to a different location such as
/tmp.RecordWriter::writeHeaderCommonnow logs when header serialization fails, pointing readers at the precedingsink-level log entries for the underlying cause.
mmaporposix_fallocate(issue Failed to write output header #731) surfaced onlyas a generic
RuntimeError: Failed to write output headerwith no diagnostic information.Test plan
tests/unit/test_tracker.pypasses against the rebuilt extension.