feat: add file upload capability #63
Closed
+350
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyundai Translead needs to upload photos and videos using the notecard.
A lot of work needs to be done to both notecard and notehub to make this happen, but it needs to be extremely straightforward from an API perspective to do so.
Given the fact that uploading a file to the notehub requires a 'chunk loop', and it already does this for DFU, the Notecard utility is the right place to put the idiomatic way to upload files so people can copy/paste from it. It also gives me a very simple and natural way to test the functions.
(Note that we can't merge this until the note-go changes are merged. Note-go changes were needed because - just as @zfields did to note-c - we need to set the serial/i2c delays to 0 during binary transfers. Those changes are on a hub ray/translead branch.)