Closed
Conversation
Raises `ValueError` for no items, instead of having an optional `None` return value, which is not useful by itself, and only complicates type checking. Adding support for `ext=None` is backward compatible, in the sense of that it would have crashed before when trying to use `.new(ext=None)`.
blueyed
force-pushed
the
makefile-ext-none
branch
from
23227d9 to
04ab747
Compare
Owner
Author
|
Closing in favor of #174 - better to have a new function for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises
ValueErrorfor no items, instead of having an optionalNonereturn value, which is not useful by itself, and only complicates type
checking.
Adding support for
ext=Noneis backward compatible, in the sense ofthat it would have crashed before when trying to use
.new(ext=None).